Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 629284 - net-dns/dnsmasq: init script reload function should use start-stop-daemon
Summary: net-dns/dnsmasq: init script reload function should use start-stop-daemon
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal minor (vote)
Assignee: Patrick McLean
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-29 13:02 UTC by Michael Orlitzky
Modified: 2017-10-02 16:37 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Orlitzky gentoo-dev 2017-08-29 13:02:00 UTC
No big deal here, but

  reload() {
      ebegin "Reloading ${SVCNAME}"
      kill -HUP $(cat "${pidfile}")
      eend $?
  }

should be

  reload() {
      ebegin "Reloading ${RC_SVCNAME}"
      start-stop-daemon --signal HUP --pidfile "${pidfile}"
      eend $?
  }

(SVCNAME has been renamed to RC_SVCNAME, too)
Comment 1 Larry the Git Cow gentoo-dev 2017-10-02 16:37:57 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5383e3fce7a501407d7a2e8c41efa766d3df2d67

commit 5383e3fce7a501407d7a2e8c41efa766d3df2d67
Author:     Patrick McLean <chutzpah@gentoo.org>
AuthorDate: 2017-10-02 16:37:09 +0000
Commit:     Patrick McLean <chutzpah@gentoo.org>
CommitDate: 2017-10-02 16:37:48 +0000

    net-dns/dnsmasq: Version bump for #632692
    
    Security version bump for these CVEs:
    CVE-2017-14491
    CVE-2017-14492
    CVE-2017-14493
    CVE-2017-14494
    CVE-2017-14495
    CVE-2017-14496
    
    Also make the relad action use start-stop-daemon.
    
    Bug: https://bugs.gentoo.org/632692
    Closes: https://bugs.gentoo.org/629284
    Package-Manager: Portage-2.3.10, Repoman-2.3.3

 net-dns/dnsmasq/Manifest                   |   1 +
 net-dns/dnsmasq/dnsmasq-2.78.ebuild        | 198 +++++++++++++++++++++++++++++
 net-dns/dnsmasq/files/dnsmasq-init-dhcp-r2 |  29 +++++
 net-dns/dnsmasq/files/dnsmasq-init-r3      |  23 ++++
 4 files changed, 251 insertions(+)