Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 627506 - www-client/firefox-55.0 won't build with sys-devel/clang-4.0.1
Summary: www-client/firefox-55.0 won't build with sys-devel/clang-4.0.1
Status: RESOLVED DUPLICATE of bug 667096
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-11 03:31 UTC by Eric Siegel
Modified: 2018-10-22 11:18 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info (emergeInfo.txt,6.22 KB, text/plain)
2017-08-11 03:31 UTC, Eric Siegel
Details
Add errno.h to list of includes (clang-errno.patch,348 bytes, patch)
2017-08-13 03:37 UTC, Eric Siegel
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Siegel 2017-08-11 03:31:21 UTC
Created attachment 488556 [details]
emerge --info

I was trying to compile firefox-55.0 - with the following USE flags: bindist, dbus, gmp-autoupdate, hwaccel, jemalloc, startup-notification - using clang (and lld) 4.0.1.

Compilation halted with the following error:

/var/tmp/portage/www-client/firefox-55.0/work/firefox-55.0/security/sandbox/linux/SandboxOpenedFiles.cpp:47:47: error: use of undeclared identifier 'errno'
SANDBOX_LOG_ERROR("dup: %s", strerror(errno));

This error did not occur with firefox-45.0.1, that compiled just fine with clanf and lld.

Here is the full build.log: http://paste.ubuntu.com/25287833/
Comment 1 Eric Siegel 2017-08-11 03:35:48 UTC
(In reply to Eric Siegel from comment #0)
> This error did not occur with firefox-54.0.1, that compiled just fine with
> clang and lld.

^^ Fixed somed typos
Comment 2 Eric Siegel 2017-08-13 03:37:43 UTC
Created attachment 488734 [details, diff]
Add errno.h to list of includes

SandboxOpenedFiles.cpp, which was not present in firefox-54.0.1, was missing the following line:

#include <errno.h>
Comment 3 Jory A. Pratt gentoo-dev 2017-09-07 13:00:13 UTC
Please test with firefox-56.0_beta9 from mozilla overlay. If you can still reproduce please feel free to reopen.
Comment 4 Eric Siegel 2017-11-17 13:29:09 UTC
Is there a difference between the www-client/firefox-57.0 ebuilds in the portage tree and the mozilla overlay?

I build firefox-58 *without* the mozilla overlay and my suggested patch was still needed to allow it to build with clang-5.0.0.
Comment 5 tt_1 2018-03-14 21:49:47 UTC
hmm, I had a quick look at the file you had to patch, and the errno.h is now included. Could you try again with 59.0, as it will hit the tree in the next time? 

Wanted to test it with arm, but there are problems with src_configure, before even starting to compile.
Comment 6 Lionel MANNONE 2018-10-22 09:35:41 UTC
I have the same error with thunderbird-60.2.1 and the patch fixes this issue
Comment 7 Thomas Deutschmann (RETIRED) gentoo-dev 2018-10-22 10:07:09 UTC

*** This bug has been marked as a duplicate of bug 667096 ***
Comment 8 Thomas Deutschmann (RETIRED) gentoo-dev 2018-10-22 11:18:43 UTC
(In reply to Lionel MANNONE from comment #6)
> I have the same error with thunderbird-60.2.1 and the patch fixes this issue

jfyi, this is now available via https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=af6aa45d9abaef36b72811c9141beeda3f4f59d0