Created attachment 487430 [details] build.log media-video/movit-1.5.2 fails to compile with several errors in resample_effect.h and resample_effect.cpp: In file included from resample_effect.cpp:20:0: resample_effect.h:44:7: error: 'unique_ptr' in namespace 'std' does not name a template type std::unique_ptr<Tap<fp16_int_t>[]> bilinear_weights_fp16; ^ resample_effect.h:45:7: error: 'unique_ptr' in namespace 'std' does not name a template type std::unique_ptr<Tap<float>[]> bilinear_weights_fp32; ^ resample_effect.cpp:209:121: error: 'unique_ptr' has not been declared unsigned combine_many_samples(const Tap<float> *weights, unsigned src_size, unsigned src_samples, unsigned dst_samples, unique_ptr<Tap<DestFloat>[]> *bilinear_weights) ^ # emerge --info '=media-video/movit-1.5.2::gentoo' Portage 2.3.6 (python 2.7.12-final-0, default/linux/amd64/13.0/desktop/plasma/systemd, gcc-5.4.0, glibc-2.23-r3, 4.12.4-gentoo x86_64) ================================================================= System Settings ================================================================= System uname: Linux-4.12.4-gentoo-x86_64-Intel-R-_Core-TM-_i7_CPU_950_@_3.07GHz-with-gentoo-2.3 KiB Swap: 2047984 total, 2047984 free Timestamp of repository gentoo: Mon, 31 Jul 2017 00:45:01 +0000 sh bash 4.3_p48-r1 ld GNU ld (Gentoo 2.28 p1.2) 2.28 distcc 3.2rc1 x86_64-pc-linux-gnu [enabled] ccache version 3.2.4 [disabled] app-shells/bash: 4.3_p48-r1::gentoo dev-java/java-config: 2.2.0-r3::gentoo dev-lang/perl: 5.24.1-r2::gentoo dev-lang/python: 2.7.12::gentoo, 3.4.5::gentoo, 3.5.3::gentoo dev-util/ccache: 3.2.4::gentoo dev-util/cmake: 3.9.0::gentoo dev-util/pkgconfig: 0.29.2::gentoo sys-apps/baselayout: 2.3::gentoo sys-apps/openrc: 0.28::gentoo sys-apps/sandbox: 2.10-r4::gentoo sys-devel/autoconf: 2.13::gentoo, 2.69::gentoo sys-devel/automake: 1.11.6-r2::gentoo, 1.15.1::gentoo sys-devel/binutils: 2.28-r2::gentoo sys-devel/gcc: 5.4.0-r3::gentoo sys-devel/gcc-config: 1.7.3::gentoo sys-devel/libtool: 2.4.6-r4::gentoo sys-devel/make: 4.2.1::gentoo sys-kernel/linux-headers: 4.10::gentoo (virtual/os-headers) sys-libs/glibc: 2.23-r3::gentoo Repositories: gentoo location: /usr/portage sync-type: rsync sync-uri: rsync://rsync.gentoo.org/gentoo-portage priority: -1000 x-portage location: /usr/local/portage masters: gentoo priority: 0 ACCEPT_KEYWORDS="amd64" ACCEPT_LICENSE="*" CBUILD="x86_64-pc-linux-gnu" CFLAGS="-march=nehalem -mtune=nehalem -mmmx -msse -msse2 -msse3 -mssse3 -mcx16 -msahf -mpopcnt -msse4.1 -msse4.2 -mfxsr -fstack-protector-strong -O3 -fomit-frame-pointer -pipe" CHOST="x86_64-pc-linux-gnu" CONFIG_PROTECT="/etc /usr/lib64/libreoffice/program/sofficerc /usr/share/config /usr/share/gnupg/qualified.txt /usr/share/maven-bin-3.3/conf" CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo" CXXFLAGS="-march=nehalem -mtune=nehalem -mmmx -msse -msse2 -msse3 -mssse3 -mcx16 -msahf -mpopcnt -msse4.1 -msse4.2 -mfxsr -fstack-protector-strong -O3 -fomit-frame-pointer -pipe" DISTDIR="/usr/portage/distfiles" EMERGE_DEFAULT_OPTS="--quiet-build=y --jobs=8 --load-average=8" FCFLAGS="-O2 -pipe" FEATURES="assume-digests binpkg-logs clean-logs config-protect-if-modified distcc distlocks ebuild-locks fail-clean fixlafiles merge-sync news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr" FFLAGS="-O2 -pipe" GENTOO_MIRRORS="..." LANG="de_DE.utf8" LC_ALL="de_DE.utf8" LDFLAGS="-Wl,-O1 -Wl,--as-needed" MAKEOPTS="-j89 -l8" PKGDIR="/usr/portage/packages" PORTAGE_CONFIGROOT="/" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git" PORTAGE_TMPDIR="/var/tmp" USE="X a52 aac acl acpi aio alsa amd64 avahi berkdb branding bzip2 cairo cdda cdr cli cracklib crypt cups cxx dbus declarative dri dts dvd dvdr emboss encode exif fam ffmpeg firefox flac fortran gallium gdbm gif glamor gphoto2 gpm gstreamer http2 iconv id3tag idn ipv6 jpeg kdbus kde kipi kwallet lastfm lcms ldap libnotify lm_sensors lzma mad matroska mng modules mp3 mp4 mpeg mtp multilib musicbrainz ncurses nls nptl nsplugin ogg opencl opengl openmp opus pam pango pcre pdf phonon plasma png policykit ppds pulseaudio qml qt3support qt4 qt5 readline samba sdl seccomp semantic-desktop session spell ssl startup-notification svg systemd tcpd theora threads tiff truetype udev udisks unicode upower usb v4l vaapi vdpau vorbis vpx vulkan widgets wxwidgets x264 x265 xattr xcb xcomposite xinerama xml xscreensaver xv xvid zeroconf zlib" ABI_X86="64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" CAMERAS="canon ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="mmx mmxext popcnt sse sse2 sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="evdev keyboard mouse wacom" KERNEL="linux" L10N="de" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LINGUAS="de" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-6" POSTGRES_TARGETS="postgres9_5" PYTHON_SINGLE_TARGET="python3_4" PYTHON_TARGETS="python2_7 python3_4" RUBY_TARGETS="ruby21 ruby22" USERLAND="GNU" VIDEO_CARDS="radeon radeonsi" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account" Unset: CC, CPPFLAGS, CTARGET, CXX, INSTALL_MASK, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON
Yes, I'm observing this too on my systems.
Same here. In file included from resample_effect.cpp:20:0: resample_effect.h:44:7: error: ‘unique_ptr’ in namespace ‘std’ does not name a template type std::unique_ptr<Tap<fp16_int_t>[]> bilinear_weights_fp16; ^ resample_effect.h:45:7: error: ‘unique_ptr’ in namespace ‘std’ does not name a template type std::unique_ptr<Tap<float>[]> bilinear_weights_fp32; ^ resample_effect.cpp:209:121: error: ‘unique_ptr’ has not been declared unsigned combine_many_samples(const Tap<float> *weights, unsigned src_size, unsigned src_samples, unsigned dst_samples, unique_ptr<Tap<DestFloat>[]> *bilinear_weights) ^ resample_effect.cpp:209:131: error: expected ‘,’ or ‘...’ before ‘<’ token unsigned combine_many_samples(const Tap<float> *weights, unsigned src_size, unsigned src_samples, unsigned dst_samples, unique_ptr<Tap<DestFloat>[]> *bilinear_weights) ^ resample_effect.cpp: In function ‘unsigned int movit::{anonymous}::combine_many_samples(const movit::Tap<float>*, unsigned int, unsigned int, unsigned int, int)’: resample_effect.cpp:224:2: error: ‘bilinear_weights’ was not declared in this scope bilinear_weights->reset(new Tap<DestFloat>[dst_samples * src_bilinear_samples]); ^ In file included from resample_effect.h:19:0, from resample_effect.cpp:20: resample_effect.cpp: In member function ‘void movit::SingleResamplePassEffect::update_texture(GLuint, const string&, unsigned int*)’: resample_effect.cpp:529:18: error: ‘struct movit::ScalingWeights’ has no member named ‘bilinear_weights_fp16’ assert((weights.bilinear_weights_fp16 == nullptr) != (weights.bilinear_weights_fp32 == nullptr)); ^ resample_effect.cpp:529:43: error: ‘nullptr’ was not declared in this scope assert((weights.bilinear_weights_fp16 == nullptr) != (weights.bilinear_weights_fp32 == nullptr)); ^ resample_effect.cpp:529:64: error: ‘struct movit::ScalingWeights’ has no member named ‘bilinear_weights_fp32’ assert((weights.bilinear_weights_fp16 == nullptr) != (weights.bilinear_weights_fp32 == nullptr)); ^ resample_effect.cpp:530:14: error: ‘struct movit::ScalingWeights’ has no member named ‘bilinear_weights_fp32’ if (weights.bilinear_weights_fp32 != nullptr) { ^ resample_effect.cpp:533:20: error: ‘struct movit::ScalingWeights’ has no member named ‘bilinear_weights_fp32’ pixels = weights.bilinear_weights_fp32.get(); ^ resample_effect.cpp: In function ‘movit::ScalingWeights movit::calculate_scaling_weights(unsigned int, unsigned int, float, float)’: resample_effect.cpp:635:2: error: ‘unique_ptr’ was not declared in this scope unique_ptr<Tap<float>[]> weights(new Tap<float>[dst_samples * src_samples]); ^ resample_effect.cpp:635:23: error: expected primary-expression before ‘[’ token unique_ptr<Tap<float>[]> weights(new Tap<float>[dst_samples * src_samples]); ^ resample_effect.cpp:635:24: error: expected primary-expression before ‘]’ token unique_ptr<Tap<float>[]> weights(new Tap<float>[dst_samples * src_samples]); ^ resample_effect.cpp:635:76: error: ‘weights’ was not declared in this scope unique_ptr<Tap<float>[]> weights(new Tap<float>[dst_samples * src_samples]); ^ resample_effect.cpp:659:28: error: expected primary-expression before ‘[’ token unique_ptr<Tap<fp16_int_t>[]> bilinear_weights_fp16; ^ resample_effect.cpp:659:29: error: expected primary-expression before ‘]’ token unique_ptr<Tap<fp16_int_t>[]> bilinear_weights_fp16; ^ resample_effect.cpp:659:32: error: ‘bilinear_weights_fp16’ was not declared in this scope unique_ptr<Tap<fp16_int_t>[]> bilinear_weights_fp16; ^ resample_effect.cpp:661:23: error: expected primary-expression before ‘[’ token unique_ptr<Tap<float>[]> bilinear_weights_fp32 = NULL; ^ resample_effect.cpp:661:24: error: expected primary-expression before ‘]’ token unique_ptr<Tap<float>[]> bilinear_weights_fp32 = NULL; ^ resample_effect.cpp:661:27: error: ‘bilinear_weights_fp32’ was not declared in this scope unique_ptr<Tap<float>[]> bilinear_weights_fp32 = NULL; ^ resample_effect.cpp:683:6: error: ‘struct movit::ScalingWeights’ has no member named ‘bilinear_weights_fp16’ ret.bilinear_weights_fp16 = move(bilinear_weights_fp16); ^ resample_effect.cpp:683:56: error: ‘move’ was not declared in this scope ret.bilinear_weights_fp16 = move(bilinear_weights_fp16); ^ resample_effect.cpp:684:6: error: ‘struct movit::ScalingWeights’ has no member named ‘bilinear_weights_fp32’ ret.bilinear_weights_fp32 = move(bilinear_weights_fp32); ^
This is both 1.5.1 and 1.5.2
Forget that last comment.
The only consumer/dependent of media-video/movit is media-libs/mlt. mlt is already compiling using C++11 features and thus links that ABI. movit was previously C++03-compatible, but now requires C++11. Building it with C++11 features and linking against that ABI should thus be fine and carried out.
(In reply to Mihai Moldovan from comment #5) > The only consumer/dependent of media-video/movit is media-libs/mlt. mlt is > already compiling using C++11 features and thus links that ABI. > > movit was previously C++03-compatible, but now requires C++11. Building it > with C++11 features and linking against that ABI should thus be fine and > carried out. Cool! But who is this a suggestion for; users or the ebuild maintainer? And do you have the concrete implications of your hints, or do you leave them to be found out by the more interested?
It's a suggestion for the maintainer. I naturally can upload a patch a bit later.
Actually, the author opted to continue using C++03: https://git.sesse.net/?p=movit;a=commitdiff;h=8e9f58fec54a4c879035b214fd7411f6ff7b3a32;hp=4a714eb0295835778f274b07df6acc4cb0889fa4 Instead of enabling C++11 support, that should probably be backported. Even though mixing binaries compiled against different ABIs is a bad idea in general... However, backporting this will lead to users running into #626604 instead. Let's wait a bit for that to get fixed.
Created attachment 487638 [details, diff] Revbump and revert C++11 usage.
Afterwards, please apply the patch in https://bugs.gentoo.org/show_bug.cgi?id=626604.
Created attachment 487642 [details, diff] Revbump and revert C++11 usage. We don't need flag-o-matic. Drop it.
The new upstream release, available as part of https://gitweb.gentoo.org/repo/gentoo.git/commit/media-video/movit?id=e1f1f16eefefd7868b26068bffdec3e99077ae6d should fix the issue and make my patch obsolete. Please close this bug report.
