Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 624884 - sys-fs/multipath-tools-0.6.4 : kpartx is never called to create partitions for multipath
Summary: sys-fs/multipath-tools-0.6.4 : kpartx is never called to create partitions fo...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal blocker (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-13 17:55 UTC by Snail
Modified: 2017-08-02 20:01 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Snail 2017-07-13 17:55:26 UTC
Hello,


There were already some bug reports created for this problem(https://bugs.gentoo.org/show_bug.cgi?id=308693 for example), but they were closed as resolved, while they are not, at least for me.
I apologize if creating a new bug report is not the right way, but I am not used to report a bug.

When creating a LUN on a SAN, and using gentoo as an initiator, it appears under /dev/mapper.
The problem is that the partitions are not created.

I digged to the /lib64/udev/rules.d/66-kpartx.rules file, provided by sys-fs/multipath-tools.

A line reads ENV{DM_TABLE_STATE}!="LIVE", GOTO="kpartx_end".
I can not figure out what its purpose is, and can not find any reference to DM_TABLE_STATE in any other udev rule.
But commenting it (putting a # in front of it) solves the problem.

So, this line should maybe be removed.

I can provide more informations if requested.
Comment 1 Jonas Stein gentoo-dev 2017-07-22 08:41:36 UTC
please add the version in the title where it is 0.0.0
Does this happen for all versions?
Comment 2 Snail 2017-07-22 09:59:05 UTC
(In reply to Jonas Stein from comment #1)
> please add the version in the title where it is 0.0.0
> Does this happen for all versions?

Hello,

I made the change requested.
Unfortunately, I do not know if this happens for all versions, because I started to use it recently. But this file appeared in 0.4.8 version.

I compared to a CENTOS machine and this file is not present (so not used) on it.
Comment 3 Snail 2017-07-23 21:17:23 UTC
Hello,

I found two interesting discussions.

1) https://www.redhat.com/archives/dm-devel/2016-April/msg00357.html
where the deleting of the kpartx rules file is considered.

2) https://www.redhat.com/archives/dm-devel/2007-July/msg00096.html
which explains that this rule was added in concert with a dmsetup patch which was never incorporated, unfortunately.
Plus, it shows that this problem was already occurring on gentoo in 2007 (!!) .
So I think that this "bug" can be set as confirmed because of this post.

On Debian, this line exists, but the value of DM_TABLE_STATE is artificially set in the /lib/udev/dmsetup_env file, to circumvent the lack of the dmsetup patch.

------------
if [ -n "$DM_UUID" ]; then
    echo DM_UUID=$DM_UUID
    ATTRS=`$DMSETUP -oattr`
    case "$ATTRS" in
        L-*) # this is the only state needed for the kpartx udev rules <<<<<<<<
            echo DM_TABLE_STATE=LIVE <<<<<<<<<<<<<<<
            echo DM_STATE=ACTIVE
            ;;
    esac
fi
----------

I discussed this problem with an upstream maintainer. I did not get a final answer yet, but I think this won't be corrected because :
- the rule file is just considered as an example
- it is "owned" by REDHAT ans SUSE, which will only allow a modification if it unifies their udev rules.

I am now convinced that this line is useless (DM_TABLE_STATE is never set) and a huge problem ( no partition is created because the rule goes directly to kpartx_end) . In my opinion, it should be removed upstream, but I am not sure that this will happen. So it should at least be removed in gentoo. Don't you agree ?
Comment 4 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2017-08-02 06:35:54 UTC
commit 92369e513e00de37fcabb3393a69d11821f3a101
Author: Lars Wendler <polynomial-c@gentoo.org>
Date:   Wed Aug 2 08:28:38 2017

    sys-fs/multipath-tools: Revbump to fix bug #624884
    
    Package-Manager: Portage-2.3.6, Repoman-2.3.3
    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>

commit 9a0b7295befa84f69322b828b401a7b0b428d00f
Author: Lars Wendler <polynomial-c@gentoo.org>
Date:   Wed Aug 2 08:18:19 2017

    sys-fs/multipath-tools: Bump to version 0.7.1
    
    This also fixes bug #624884
    
    Package-Manager: Portage-2.3.6, Repoman-2.3.3
    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>
Comment 5 Snail 2017-08-02 20:01:30 UTC
Hello,

I can confirm that the bug is fixed since the line is removed.

Thank you.