624854 – genkernel to include nvme support by default

Bug 624854 - genkernel to include nvme support by default

Summary: genkernel to include nvme support by default

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Gentoo Genkernel Maintainers

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2017-07-13 09:30 UTC by cedric.lood
Modified:	2017-09-04 02:54 UTC (History)
CC List:	2 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description cedric.lood 2017-07-13 09:30:18 UTC

As NVMe drive become more common, I suggest making setting the following options by default in kernels generated by genkernel:

Device Drivers  --->

  ...
  <*> NVM Express block device      
  ...
  [*] Open-Channel SSD target support  --->


At the moment, the first setting is set to <M>, the second is < >. Which means default (vanilla) install as described in the installation guide will fail to boot if the user has a nvme hdd and uses genkernel.

Best,
Cedric

Comment 1 tdr 2017-07-13 09:53:38 UTC

Maybe M vs * for the drivers, but agree it should be considered.

At least a few folks using nvme devices have needed help with this recently on #gentoo.

Comment 2 Robin Johnson archtester

2017-07-14 18:24:07 UTC

Is this enough options for you?
CONFIG_NVME_CORE=m
CONFIG_BLK_DEV_NVME=m
CONFIG_BLK_DEV_NVME_SCSI=y
CONFIG_NVM=y
CONFIG_NVM_RRPC=m

Comment 3 Clin 2017-09-02 02:01:27 UTC

Also experiencing this issue and have been for some time, is there any ETA on a fix?

Comment 4 Robin Johnson archtester

2017-09-02 02:09:21 UTC

(In reply to Clin from comment #3)
> Also experiencing this issue and have been for some time, is there any ETA
> on a fix?

3.5.1.1 ships with CONFIG_BLK_DEV_NVME=m, which also selects CONFIG_NVME_CORE. Does this not work for you?

Nobody else commented if they needed other Kconfig options.

Comment 5 Robin Johnson archtester

2017-09-02 02:09:57 UTC

Clin: you added a comment with CC'ing yourself, please see my remark in comment 4

Comment 6 Larry the Git Cow gentoo-dev

2017-09-04 02:54:52 UTC

Bug has been closed via the following commit:
    https://gitweb.gentoo.org/proj/genkernel.git/commit/?id=f7664921cf99cb1072215c488bb7a5f4018ff419

    commit f7664921cf99cb1072215c488bb7a5f4018ff419
Author:     Robin H. Johnson <robbat2@gentoo.org>
AuthorDate: 2017-09-04 02:54:05 +0000
Commit:     Robin H. Johnson <robbat2@gentoo.org>
CommitDate: 2017-09-04 02:54:05 +0000

    defaults/kernel-generic-config: NVME support.
    
    Ensure NVME kernel is built for all platforms.
    
    Fixes: https://bugs.gentoo.org/624854
    Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>

 defaults/kernel-generic-config | 5 +++++
 1 file changed, 5 insertions(+)