Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 624038 - net-misc/asterisk-* init script leaks stdout+stderr to sub-process
Summary: net-misc/asterisk-* init script leaks stdout+stderr to sub-process
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Jaco Kroon
URL:
Whiteboard:
Keywords: PullRequest
Depends on: 594964
Blocks:
  Show dependency tree
 
Reported: 2017-07-06 17:39 UTC by Jaco Kroon
Modified: 2020-03-20 09:09 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jaco Kroon 2017-07-06 17:39:59 UTC
Tony,

As you know I do somewhat evil stuff with ucarp and asterisk.  So I ended up finding a very interesting one.  Short version, please update the asterisk init script with this for me:

--- a/init.d/asterisk
+++ b/init.d/asterisk
@@ -261,7 +261,7 @@ start() {
 
        checkpath -d -m 0755 -o "${ast_user}:${ast_group}" "${ast_logdir}" "${ast_rundir}"
        einfo "Starting asterisk as      : ${ast_user}:${ast_group}"
-       asterisk_run_loop ${OPTS} 2>&1 | logger -t "wrapper:${ast_instancename}" &
+       asterisk_run_loop ${OPTS} 2>&1 | logger -t "wrapper:${ast_instancename}" &>/dev/null &
        result=$?
 
        if [ $result -eq 0 ]; then

The longer version is that my ucarp init script does a bunch of things, amongst others (simplified):

/path/to/some/other/script | logger -t vip-up(instancename)

Where that script does /etc/init.d/asterisk.instancename start

The above causes the logger from ucarp to have it's stdin never closed (stdout + stderr from the logger command is the write-end of the read-pipe going into the outer logger), resulting in the vip-up script never completing since the logger never quits resulting in bad stuff happening at the ucarp level (ucarp really should fork out the vip-up/down scripts and start advertising).  I really need a replacement for ucarp for my purposes but the existing alternatives currently aren't looking more promising either.

Reproducible: Always
Comment 1 Jaco Kroon 2017-11-06 10:13:35 UTC
Hi Tony,

This bit me again.  And we're deploying additional servers this week where this would be a problem too.

Would really appreciate if this can be pushed out at some point please.
Comment 2 Jaco Kroon 2017-11-15 21:31:47 UTC
The init script in bug 594964 fixes this too.  When that gets resolved this can be resolved.
Comment 3 Larry the Git Cow gentoo-dev 2020-03-20 09:09:58 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bef6c9937500cd1ff103da2117d7e20f268cfa47

commit bef6c9937500cd1ff103da2117d7e20f268cfa47
Author:     Jaco Kroon <jaco@uls.co.za>
AuthorDate: 2020-03-15 18:45:40 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2020-03-20 09:09:29 +0000

    net-misc/asterisk: version bump 13.32.0
    
    Normal release.
    
    Issues reported to Gentoo fixed from upstream was mysql's my_bool that
    went away.
    
    Include patches for binutils 2.34 (also submitted upstream so expect
    removal in next release).
    
    Also includes various init script improvements I've been running with
    for a while now.
    
    Closes: https://bugs.gentoo.org/594964
    Closes: https://bugs.gentoo.org/624038
    Closes: https://bugs.gentoo.org/710484
    Closes: https://bugs.gentoo.org/711582
    Package-Manager: Portage-2.3.89, Repoman-2.3.20
    Signed-off-by: Jaco Kroon <jaco@uls.co.za>
    Closes: https://github.com/gentoo/gentoo/pull/14986
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 net-misc/asterisk/Manifest                         |   1 +
 net-misc/asterisk/asterisk-13.32.0.ebuild          | 332 ++++++++++++++++++
 .../files/asterisk-13.32.0-binutils-2.34.patch     |  17 +
 .../asterisk-historic-dahdiras-without-root.patch  |  23 ++
 .../asterisk-historic-dundi-null-dereference.patch |  40 +++
 ...terisk-historic-invert-gmine-search-order.patch |  12 +
 .../asterisk-historic-no-var-run-install.patch     |  14 +
 .../asterisk/files/asterisk-historic-uclibc.patch  |  23 ++
 net-misc/asterisk/files/confd-13.32.0              | 160 +++++++++
 net-misc/asterisk/files/initd-13.32.0              | 380 +++++++++++++++++++++
 10 files changed, 1002 insertions(+)