Created attachment 478430 [details] New ebuild to handle changes from 2017-03-03 Starting with the commit https://github.com/SupSuper/OpenXcom/commit/52f06609e57acafa42e0dd6cdb138f87aee818e4 git version of OpenXCom fails at configure stage. Line 30 of the ebuild sed -i -e '/\/res\//d' CMakeLists.txt || die removes installation of the desktop shortcut and icons. But in the new CMakeLists.txt the corresponding lines are split in two and sed removes only the first halves. This results in unmatched parentheses and CMake refuses to work. Possible solutions are either installing the icons and the shortcut, using a different sed expression, or using a patch file. The attached ebuild has a second sed expression sed -i -e '/CMAKE_INSTALL_FULL_DATAROOTDIR/d' CMakeLists.txt || die
This seems to be still unfixed? I got this today: >>> Configuring source in /var/tmp/portage/games-engines/openxcom-9999/work/openxcom-9999 ... >>> Working in BUILD_DIR: "/var/tmp/portage/games-engines/openxcom-9999/work/openxcom-9999_build" cmake -C /var/tmp/portage/games-engines/openxcom-9999/work/openxcom-9999_build/gentoo_common_config.cmake -G Unix Makefiles -DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_BUILD_TYPE=Gentoo -DCMAKE_USER_MAKE_RULES_OVERRIDE=/var/tmp/portage/games-engines/openxcom-9999/work/openxcom-9999_build/gentoo_rules.cmake -DCMAKE_TOOLCHAIN_FILE=/var/tmp/portage/games-engines/openxcom-9999/work/openxcom-9999_build/gentoo_toolchain.cmake /var/tmp/portage/games-engines/openxcom-9999/work/openxcom-9999 loading initial cache file /var/tmp/portage/games-engines/openxcom-9999/work/openxcom-9999_build/gentoo_common_config.cmake CMake Error at CMakeLists.txt:177: Parse error. Expected "(", got quoted argument with text "${CMAKE_INSTALL_FULL_DATAROOTDIR}/applications". -- Configuring incomplete, errors occurred! * ERROR: games-engines/openxcom-9999::gentoo failed (configure phase): * cmake failed * * Call stack: * ebuild.sh, line 124: Called src_configure * environment, line 3857: Called cmake-utils_src_configure * environment, line 1128: Called die * The specific snippet of code: * "${CMAKE_BINARY}" "${cmakeargs[@]}" "${CMAKE_USE_DIR}" || die "cmake failed"; * * If you need support, post the output of `emerge --info '=games-engines/openxcom-9999::gentoo'`, * the complete build log and the output of `emerge -pqv '=games-engines/openxcom-9999::gentoo'`. * The complete build log is located at '/var/tmp/portage/games-engines/openxcom-9999/temp/build.log'. * The ebuild environment file is located at '/var/tmp/portage/games-engines/openxcom-9999/temp/environment'. * Working directory: '/var/tmp/portage/games-engines/openxcom-9999/work/openxcom-9999_build' * S: '/var/tmp/portage/games-engines/openxcom-9999/work/openxcom-9999' >>> Failed to emerge games-engines/openxcom-9999, Log file: >>> '/var/tmp/portage/games-engines/openxcom-9999/temp/build.log'
I use cmake version 3.10.1.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c2604083a27e801f8643835d43fefbf846e9f434 commit c2604083a27e801f8643835d43fefbf846e9f434 Author: James Le Cuirot <chewi@gentoo.org> AuthorDate: 2018-03-17 21:14:26 +0000 Commit: James Le Cuirot <chewi@gentoo.org> CommitDate: 2018-03-17 21:27:36 +0000 games-engines/openxcom: Fix 9999 icons and desktop file installation sed broke CMakeLists.txt but this is no longer necessary anyway as upstream now use GNUInstallDirs. Closes: https://bugs.gentoo.org/623058 Package-Manager: Portage-2.3.24, Repoman-2.3.6 games-engines/openxcom/openxcom-9999.ebuild | 24 ++++-------------------- 1 file changed, 4 insertions(+), 20 deletions(-)
