Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 622712 - net-wireless/bluez + USE="extra-tools readline" = fail on ~arch branch versions
Summary: net-wireless/bluez + USE="extra-tools readline" = fail on ~arch branch versions
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Pacho Ramos
URL:
Whiteboard:
Keywords: PATCH
: 624372 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-06-25 20:29 UTC by tdr
Modified: 2017-07-16 11:51 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch for bluez-5.45.ebuild (patch_for_bluez-5.45.ebuild.patch,881 bytes, patch)
2017-06-25 21:16 UTC, tdr
Details | Diff
patch for blues-5.44.ebuild (patch_for_bluez-5.44.ebuild.patch,876 bytes, patch)
2017-06-25 21:22 UTC, tdr
Details | Diff
patch for blues-5.45.ebuild (patch_for_bluez-5.45.ebuild.patch,881 bytes, patch)
2017-06-25 21:32 UTC, tdr
Details | Diff
corrected patch for bluez-5.44 (patch_for_bluez-5.44.ebuild.patch,876 bytes, patch)
2017-06-26 17:07 UTC, tdr
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description tdr 2017-06-25 20:29:00 UTC
If USE has extra-tools enabled, a conditional if USE readline is hit, if readline is also enabled, then a doins for attrib/gatttool is triggered that fails.

Effects ~arch net-wireless/bluez accross all architectures.

Reproducible: Always

Steps to Reproduce:
USE="readline extra-tools" emerge =bluez-5.44  

or 

USE="readline extra-tools" emerge =bluez-5.45



Actual Results:  
everything good until:

     *   dobin failed
.
.
.

     * QA Notice: file does not exist:
     * 
     * 	dobin: attrib/gatttool does not exist



Expected Results:  
Normal merge with successful dobin of attrib/gatttool



gatttool binary is not present anywhere in the source tarball, after configure stage, or compiled work directory for either testing branch version (5.44 and 5.45):


box bluez # find /var/tmp/portage/net-wireless/bluez-5.45/work -name gatttool   
box bluez # 

net-wireless/bluez-5.44 has the same missing file:
 * S: '/var/tmp/portage/net-wireless/bluez-5.44/work/bluez-5.44'
 * QA Notice: file does not exist:
 * 
 * 	dobin: attrib/gatttool does not exist


The other dobin line of the conditional stanza is successful if the first is removed.

Offending line for both 5.44 and 5.45 versions is line 191.

Stable branch version 5.43-r1 is not effected.
Comment 1 tdr 2017-06-25 21:16:21 UTC
Created attachment 478012 [details, diff]
patch for bluez-5.45.ebuild

requires deprecated USE flag is extra-tools USE is enabled
Comment 2 tdr 2017-06-25 21:22:15 UTC
Created attachment 478014 [details, diff]
patch for blues-5.44.ebuild

adds USE dep of deprecated if USE extra-tools is enabled + sorts out nested conditional for dobin
Comment 3 tdr 2017-06-25 21:32:50 UTC
Created attachment 478016 [details, diff]
patch for blues-5.45.ebuild

adds required USE of deprecated if extra-tools USE is enabled

removes nested conditional before dobins
   --no need for nested since extra-tools already requires readline
Comment 4 tdr 2017-06-25 21:34:25 UTC
Upstream has moved the gatttool binary build behind the "deprecated" switch.

https://git.kernel.org/pub/scm/bluetooth/bluez.git/commit/?id=b1eb2c4cd057624312e0412f6c4be000f7fc3617


Submitted patches for both 5.45 and 5.45 ebuilds
Comment 5 tdr 2017-06-26 17:07:55 UTC
Created attachment 478092 [details, diff]
corrected patch for bluez-5.44
Comment 6 Pacho Ramos gentoo-dev 2017-07-10 10:43:45 UTC
*** Bug 624372 has been marked as a duplicate of this bug. ***
Comment 7 Pacho Ramos gentoo-dev 2017-07-16 11:51:29 UTC
[master fbab5968fa5] net-wireless/bluez: Version bump, fix extra-tools (#622712 by Ted Rodgers)
 2 files changed, 254 insertions(+)
 create mode 100644 net-wireless/bluez/bluez-5.46.ebuild