Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 620408 - net-irc/quasselgrep New package I'd like to proxy maintain.
Summary: net-irc/quasselgrep New package I'd like to proxy maintain.
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal enhancement
Assignee: Proxy Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-02 07:52 UTC by ephemer0l
Modified: 2017-07-03 12:52 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
net-irc/quasselgrep/quasselgrep-9999.ebuild (file_620408.txt,607 bytes, text/plain)
2017-06-02 07:52 UTC, ephemer0l
Details
net-irc/quasselgrep-(9999|20170411).ebuild (file_620408.txt,894 bytes, text/plain)
2017-06-02 22:21 UTC, ephemer0l
Details
metadata.xml (file_620408.txt,372 bytes, text/plain)
2017-06-02 22:24 UTC, ephemer0l
Details
net-irc/quasselgrep-(9999|20170411).ebuild (file_620408.txt,951 bytes, text/plain)
2017-06-04 19:32 UTC, ephemer0l
Details
metadata.xml (file_620408.txt,393 bytes, text/plain)
2017-06-11 03:11 UTC, ephemer0l
Details
net-irc/quasselgrep/quasselgrep-9999.ebuild (file_620408.txt,1000 bytes, text/plain)
2017-06-11 03:12 UTC, ephemer0l
Details
SilverCity Library License (file_620408.txt,2.47 KB, text/plain)
2017-06-11 17:40 UTC, ephemer0l
Details

Note You need to log in before you can comment on or make changes to this bug.
Description ephemer0l 2017-06-02 07:52:51 UTC
Created attachment 474970 [details]
net-irc/quasselgrep/quasselgrep-9999.ebuild

Quasselgrep is a tool for searching quassel logs from the commandline. It's currently a live ebuild. I have reached out to the developer to request a tagged release with hopes it can eventually be stabilized.
Comment 1 ephemer0l 2017-06-02 22:21:20 UTC
Created attachment 475044 [details]
net-irc/quasselgrep-(9999|20170411).ebuild

Fixed ebuild to be live, as well as tagged to a commit.
Comment 2 ephemer0l 2017-06-02 22:24:51 UTC
Created attachment 475046 [details]
metadata.xml

metadata.xml if I'm eligible to proxy-maintain this package
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2017-06-04 08:29:23 UTC
Wait, so there is a better way than playing with the sqlite db directly?!
Comment 4 ephemer0l 2017-06-04 19:32:34 UTC
Created attachment 475172 [details]
net-irc/quasselgrep-(9999|20170411).ebuild

With advice from dilfridge I changed the deps to require the python version.
Comment 5 Sam Jorna (wraeth) (RETIRED) gentoo-dev 2017-06-07 14:05:48 UTC
This looks good so far, though there are a couple of things that will need to be addressed for this ebuild:

 - python needs to be built with USE=sqlite - look into PYTHON_REQ_USE
 - unused variables such as IUSE and DEPEND don't need to be declared if not used

The live version doesn't build at present - ${S} is set incorrectly. This will need to be fixed if you want to keep the live ebuild, otherwise just the version-pinned one can be added.

Also, if the intention is for upstream to tag "proper" versions, you should version this ebuild as though it's a patch on v0 of upstream, making it "quasselgrep-0_p20170411". https://devmanual.gentoo.org/ebuild-writing/file-format/

If you want to keep the live ebuild, can you fix the above points and test that they build; otherwise let me know and I can make the changes as I commit.
Comment 6 Sam Jorna (wraeth) (RETIRED) gentoo-dev 2017-06-07 14:15:41 UTC
Also, so you're aware, the email address in metadata.xml should be the same as your email on bugzilla. I can update this as I commit as well, but I wanted to point it out.
Comment 7 ephemer0l 2017-06-11 03:11:13 UTC
Created attachment 475982 [details]
metadata.xml

Update email address
Comment 8 ephemer0l 2017-06-11 03:12:55 UTC
Created attachment 475984 [details]
net-irc/quasselgrep/quasselgrep-9999.ebuild

Can/should/does also work as quasselgrep-0_p20170411.ebuild
Comment 9 ephemer0l 2017-06-11 17:40:43 UTC
Created attachment 476070 [details]
SilverCity Library License

This is defined in the source, here:
https://github.com/Komodo/KomodoEdit/blob/d0fe723a7d39d08a207b8d45a94bd12cb756b039/src/silvercity/LICENSE.txt
Comment 10 ephemer0l 2017-06-11 17:41:26 UTC
Comment on attachment 476070 [details]
SilverCity Library License

Wrong bug :-/ Sorry for noise.
Comment 11 Sam Jorna (wraeth) (RETIRED) gentoo-dev 2017-07-03 12:52:24 UTC
This has now been committed - thanks!

As I mentioned, there were a couple changes made to the ebuild to make it commit ready:

 - The USE-dependency "python[sqlite]" was moved to PYTHON_REQ_USE (I mentioned it in comment 5);
 - the KEYWORDS defined in global scope was overriding the one defined for the 9999 build, so that was moved into the if/then statement;
 - There was a missing "${PYTHON_USEDEP}" on psycopg

If you want me to explain any of those, feel free to ping me on IRC. Otherwise, good work!


commit 4dcf3260e40b29e2cb44010685706234feeb7ee7 (HEAD -> master)
Author: Sam Jorna <wraeth@gentoo.org>
Date:   Mon Jul 3 22:44:18 2017 +1000

    net-irc/quasselgrep: new package
    
    New package submitted by ephemer0l for searching Quassel logs.
    
    Gentoo-bug: 620408
    Package-Manager: Portage-2.3.6, Repoman-2.3.2