Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 620164 - <sys-devel/gcc-6 part of the documentation building is broken with >=dev-lang/perl-5.26.0
Summary: <sys-devel/gcc-6 part of the documentation building is broken with >=dev-lang...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Toolchain Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-29 18:24 UTC by Andreas K. Hüttel
Modified: 2017-10-27 22:45 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch (gcc-5-perl-5.26.patch,1.12 KB, patch)
2017-05-29 18:24 UTC, Andreas K. Hüttel
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas K. Hüttel archtester gentoo-dev 2017-05-29 18:24:47 UTC
Created attachment 474674 [details, diff]
patch

Soon to be released Perl 5.26 turns an old deprecation into a fatal error. 

Unescaped left brace in regex is deprecated, passed through in regex; marked by <-- HERE in m/^\@strong{ <-- HERE (.*)}$/ at /var/tmp/portage/sys-devel/gcc-4.9.4/work/gcc-4.9.4/gcc/../contrib/texi2pod.pl line 319.
Unescaped left brace in regex is deprecated, passed through in regex; marked by <-- HERE in m/^\@strong{ <-- HERE (.*)}$/ at /var/tmp/portage/sys-devel/gcc-4.9.4/work/gcc-4.9.4/libjava/classpath/doc/texi2pod.pl line 314.

Attached patch should fix the problem. Build tested for 5.4.0, applies also to 4.9.4 and 4.9.3, most likely also needed for earlier versions.
Comment 1 Andreas K. Hüttel archtester gentoo-dev 2017-07-09 16:04:06 UTC
Luckily the failure is just ignored by the Makefile, and since this is documentation generation, the impact is limited.
Comment 2 Matthias Maier gentoo-dev 2017-08-06 15:02:50 UTC
Bumped patchsets and prepared ebuilds. Please test and restore keywords.


commit a5437645049f11f7cad688bdeda4b06b17d296f6
Author: Matthias Maier <tamiko@gentoo.org>
Date:   Sun Aug 6 09:55:30 2017 -0500

    sys-devel/gcc: 5.4.0-r4, bump patchset to 1.4, fix for bug #620164
    
    Package-Manager: Portage-2.3.6, Repoman-2.3.3

commit b877bfb4aaca027ba7e1da6945da5b4bf87cb063
Author: Matthias Maier <tamiko@gentoo.org>
Date:   Sun Aug 6 09:54:00 2017 -0500

    sys-devel/gcc: 4.9.4, bump patchset to 1.1, fix for bug #620164
    
    Package-Manager: Portage-2.3.6, Repoman-2.3.3
Comment 3 Andreas K. Hüttel archtester gentoo-dev 2017-08-24 19:16:33 UTC
commit 3cf4882da013d6b84dcc3a5823df7d27b3dafdb6 (HEAD -> master, origin/master, origin/HEAD)
Author: Andreas K. Hüttel <dilfridge@gentoo.org>
Date:   Thu Aug 24 20:51:26 2017 +0200

    sys-devel/gcc: Bump patchset in -r3 to add build fix for bug 620164; remove unkeyworded -r4
    
    Package-Manager: Portage-2.3.8, Repoman-2.3.3
Comment 4 Andreas K. Hüttel archtester gentoo-dev 2017-08-24 19:19:34 UTC
>     sys-devel/gcc: Bump patchset in -r3 to add build fix for bug 620164;
> remove unkeyworded -r4
>     
>     Package-Manager: Portage-2.3.8, Repoman-2.3.3

Somebody who's been testing it can do the same with 4.9.4. In any case, since this is now fixed in newest stable and in newest ~arch, it shouldnt block Perl unmasking anymore.
Comment 5 Jaak Ristioja 2017-08-25 06:06:46 UTC
(In reply to Andreas K. Hüttel from comment #3)
> commit 3cf4882da013d6b84dcc3a5823df7d27b3dafdb6 (HEAD -> master,
> origin/master, origin/HEAD)
> Author: Andreas K. Hüttel <dilfridge@gentoo.org>
> Date:   Thu Aug 24 20:51:26 2017 +0200
> 
>     sys-devel/gcc: Bump patchset in -r3 to add build fix for bug 620164;
> remove unkeyworded -r4

As a user with sys-devel/gcc:5.4.0 ** in /etc/portage/package.accept_keywords, can you please clarify this for me a bit:

So downgrading sys-devel/gcc from 5.4.0-r4 to 5.4.0-r3 is actually an upgrade?

Thanks!
Comment 6 Andreas K. Hüttel archtester gentoo-dev 2017-08-26 09:39:46 UTC
(In reply to Jaak Ristioja from comment #5)
> >     sys-devel/gcc: Bump patchset in -r3 to add build fix for bug 620164;
> > remove unkeyworded -r4
> 
> As a user with sys-devel/gcc:5.4.0 ** in
> /etc/portage/package.accept_keywords, can you please clarify this for me a
> bit:
> 
> So downgrading sys-devel/gcc from 5.4.0-r4 to 5.4.0-r3 is actually an
> upgrade?

It's a rebuild of the same source. :)
Comment 7 Andreas K. Hüttel archtester gentoo-dev 2017-10-03 20:53:56 UTC
Did anyone in the meantime test 4.9.4-r1 ?
Comment 8 Larry the Git Cow gentoo-dev 2017-10-27 22:45:53 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6aa7db52ea50c53895d3c929ae05a8d38add3594

commit 6aa7db52ea50c53895d3c929ae05a8d38add3594
Author:     Sergei Trofimovich <slyfox@gentoo.org>
AuthorDate: 2017-10-27 22:44:37 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2017-10-27 22:45:47 +0000

    sys-devel/gcc: bump 4.9.4 patch set up to 1.2, bug #629502
    
    Patchset contains the following new patches (picked as-is from 5.4.0):
    - 94_all_compatibility_fix_with_perl_5.26.patch: regex tweak for perl-5.26
    - 95_all_asan-signal_h.patch: add missing '<signal.h>' header
    - 96_all_ucontext-to-ucontext_t.patch: change 'struct ucontext' to 'ucontext_t'
    - 97_all_no-sigaltstack.patch: remove 'sigaltstack' usage
    to fix gcc-4.9.4 build failure against glibc-2.26.
    
    I've deleted 4.9.4-r1 as it contained single build-time fix for perl-5.26.
    
    Closes: https://bugs.gentoo.org/629502
    Closes: https://bugs.gentoo.org/620164
    Package-Manager: Portage-2.3.12, Repoman-2.3.4

 sys-devel/gcc/Manifest            |  3 +--
 sys-devel/gcc/gcc-4.9.4-r1.ebuild | 47 ---------------------------------------
 sys-devel/gcc/gcc-4.9.4.ebuild    |  4 ++--
 3 files changed, 3 insertions(+), 51 deletions(-)