619966 – net-wireless/reaver: uses doman on compressed file

Bug 619966 - net-wireless/reaver: uses doman on compressed file

Summary: net-wireless/reaver: uses doman on compressed file

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Maxim Koltsov (RETIRED)

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	doman-compressed
	Show dependency tree

Reported:	2017-05-28 09:23 UTC by Michał Górny
Modified:	2018-04-18 11:28 UTC (History)
CC List:	3 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Decompress man page (reaver-1.4-r3.patch,595 bytes, patch) 2017-05-28 10:59 UTC, Oleh Kravchenko	Details \| Diff
Decompress man page (reaver-1.4-r3.patch,602 bytes, patch) 2017-06-23 18:33 UTC, Oleh Kravchenko	Details \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michał Górny archtester

2017-05-28 09:23:13 UTC

The package uses doman/newman on a compressed file which is invalid per PMS:

   doman ../docs/reaver.1.gz

Comment 1 Oleh Kravchenko 2017-05-28 10:59:43 UTC

Created attachment 474540 [details, diff]
Decompress man page

Comment 2 Michał Górny archtester

2017-06-23 09:06:10 UTC

Comment on attachment 474540 [details, diff]
Decompress man page

>diff --git a/net-wireless/reaver/reaver-1.4-r3.ebuild b/net-wireless/reaver/reaver-1.4-r3.ebuild
>index 393abcd1a365..4c5068e3a7e1 100644
>--- a/net-wireless/reaver/reaver-1.4-r3.ebuild
>+++ b/net-wireless/reaver/reaver-1.4-r3.ebuild
>@@ -33,6 +33,9 @@ PATCHES=(
> 
> src_compile() {
> 	emake V=1
>+
>+	# doman accept only uncompressed files #619966
>+	gzip -d ../docs/reaver.1.gz

This needs ||die.

> }
> 
> src_install() {
>@@ -41,6 +44,6 @@ src_install() {
> 	insinto "/var/db/reaver"
> 	doins reaver.db
> 
>-	doman ../docs/reaver.1.gz
>+	doman ../docs/reaver.1
> 	dodoc ../docs/README ../docs/README.REAVER ../docs/README.WASH
> }

Comment 3 Oleh Kravchenko 2017-06-23 18:33:52 UTC

Created attachment 477718 [details, diff]
Decompress man page

Add "die"

Comment 4 Jonas Stein gentoo-dev

2018-04-09 20:41:34 UTC

Maxim, what do you think about the patch? Should we merge it?

Comment 5 Larry the Git Cow gentoo-dev

2018-04-18 11:28:02 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b3e7cfd384976319c67911270d839d64f7e9f488

commit b3e7cfd384976319c67911270d839d64f7e9f488
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2018-04-18 11:25:46 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2018-04-18 11:27:55 +0000

    net-wireless/reaver: Unpack manpage before installing
    
    Patch-by: Oleh Kravchenko <oleg@kaa.org.ua>
    Closes: https://bugs.gentoo.org/619966

 net-wireless/reaver/reaver-1.4-r3.ebuild | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)