Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 618260 - dev-lang/rakudo is out of date. 2017.04.3 patch has been released which contains fixes for a serious regex bug
Summary: dev-lang/rakudo is out of date. 2017.04.3 patch has been released which conta...
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Patrick Lauer
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-12 00:32 UTC by Samantha McVey
Modified: 2017-05-19 23:21 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
f0db8822 49c93fe2 21bfb7ef Commits fixing case insensitive regex bug (2017.04-case-insensitive-regex-bug.patch,5.18 KB, patch)
2017-05-13 00:41 UTC, Samantha McVey
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Samantha McVey 2017-05-12 00:32:18 UTC
I'm one of the Perl 6 developers. I noticed the package was still 2017.04.2 which doesn't have the patch fix in .3

There will be no more point releases for this month.

Reproducible: Always
Comment 1 Samantha McVey 2017-05-12 02:27:48 UTC
Also wanted to add that our Rakudo Star distribution that happens about once every 3 months is based on 2017.04.3 as well.

These are the tags:

NQP: 2017.04-24-g87501f7b
MoarVM: 2017.04-44-gf0db8822

These are the tagged versions of nqp and MoarVM.
Comment 2 Jonas Stein gentoo-dev 2017-05-12 22:05:54 UTC
Thank you. Can you provide more information on the "serious regex bug", please?
Comment 3 Samantha McVey 2017-05-13 00:14:53 UTC
Case insensitive regex will have a false positive if the start of the needle and end of the haystack are the same. Only one character needs to be the same.

'c' ~~ m:i/abc/ # will cause a match

'fgh' ~~ m:i/h29010/ # will also match

Only affects case insensitive regex.

I was working on building newer versions and I am decided it will be much easier to just apply a patch to MoarVM than having to update the whole chain, since it looks like Rakudo had a release based on the fixed MoarVM, even though NQP and MoarVM did not have official releases on their site/git tags.

I was the one who fixed the bug so I can provide a patch for MoarVM so that that is the only thing that needs to be updated.
Comment 4 Samantha McVey 2017-05-13 00:41:17 UTC
Created attachment 472456 [details, diff]
f0db8822 49c93fe2 21bfb7ef Commits fixing case insensitive regex bug

I have tested this patch against our updated set of tests and everything passes.

Since NQP and MoarVM haven't had tagged releases, if this patch is applied this issue can be closed (since I did not realize at time of opening the ticket that NQP and MoarVM didn't have tagged releases despite Rakudo having had one).

Thank you!
Comment 5 Patrick Lauer gentoo-dev 2017-05-19 23:21:55 UTC
Yes, since there's no releases for the other bits the .3 release can't be properly packaged. It's a sad story :)