Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 617818 - media-sound/easytag-2.4.3 corrupts Ogg, Opus, needs warning / masking
Summary: media-sound/easytag-2.4.3 corrupts Ogg, Opus, needs warning / masking
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal critical
Assignee: Gentoo Sound Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-08 08:26 UTC by Florian Berger
Modified: 2024-07-06 22:00 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Prevent corruption of Ogg container (easytag-revert-open-handle-ogg.patch,6.54 KB, patch)
2018-11-27 13:49 UTC, Patrice Levesque
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Berger 2017-05-08 08:26:54 UTC
media-sound/easytag is a tool to edit tags of audio files.

media-sound/easytag-2.4.3 has the confirmed issue of corrupting Ogg and Opus files, rendering them defunct for some players.

See upstream bug reports:

https://bugzilla.gnome.org/show_bug.cgi?id=776110

https://bugzilla.gnome.org/show_bug.cgi?id=779649

https://bugzilla.gnome.org/show_bug.cgi?id=780055

The corruption passes unnoticed while using EasyTag, it only becomes apparent once one tries to play back the processed files. Without a backup, the corruption is irreversible, and requires a re-encoding of the files.

As this hat severly bitten users after e.g. ripping and tagging hours of audio, and no upstream fix is available, Gentoo should probably mask media-sound/easytag-2.4.3. media-sound/easytag-2.1.8 is still in the tree and not affected by this bug.

An alternative would be to output a warning after installation that Ogg and Opus files will be corrupted by this version.

Other formats as MP3 or FLAC are apparently not affected by this bug, so EasyTag is still usable for these.

Thanks for considering.
Comment 1 Patrice Levesque 2018-11-27 13:48:37 UTC
It appears the commit that causes corruption is known and that OpenSuSE fixes it with a patch that undoes the commit: https://build.opensuse.org/request/show/596947

Attaching the patch for this in a few seconds; ideally it should be part of a revised ebuild.
Comment 2 Patrice Levesque 2018-11-27 13:49:22 UTC
Created attachment 556456 [details, diff]
Prevent corruption of Ogg container
Comment 3 arcctgx 2018-12-02 14:52:46 UTC
I'm surprised to see this is still "Unconfirmed" after more than a year. The root cause was identified in the discussion at EasyTAG's Bugzilla [1].

I'm having exactly the same issue with easytag-2.4.3 in Gentoo, and I can confirm that the attached patch which reverts the offending upstream commit e5c640ca3f fixes this.

I tested by first modifying an Ogg Vorbis file with patched EasyTAG. Then I ran ogginfo on the modified file and saw no "Negative or zero granulepos" errors. Finally, I used my hardware player to play this modified file, and it was successful (previously it was crashing when I attempted to play a file corrupted by EasyTAG).

Please consider patching this in Gentoo. It is important because the upstream development has stalled, and we're stuck with a buggy version now.

[1] https://bugzilla.gnome.org/show_bug.cgi?id=776110
Comment 4 Larry the Git Cow gentoo-dev 2018-12-02 18:43:48 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=645351f868ac449b80ad507dd46ad0ccb1c3874e

commit 645351f868ac449b80ad507dd46ad0ccb1c3874e
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2018-12-02 17:41:23 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2018-12-02 18:43:35 +0000

    media-sound/easytag: Fix ogg corruption
    
    Non-maintainer commit. (Revert) Patch taken from openSUSE.
    
    See also: https://bugzilla.gnome.org/show_bug.cgi?id=776110
    Reported-by: Florian Berger <florian.berger@posteo.de>
    Thanks-to: Patrice Levesque <gentoo.wayne@ptaff.ca>
    Closes: https://bugs.gentoo.org/617818
    Package-Manager: Portage-2.3.52, Repoman-2.3.12
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 media-sound/easytag/easytag-2.4.3-r1.ebuild        |  72 ++++++
 .../files/easytag-2.4.3-ogg-corruption.patch       | 246 +++++++++++++++++++++
 2 files changed, 318 insertions(+)
Comment 5 Luke Gompertz 2024-07-06 12:22:33 UTC
There appears to be a regression on this bug. I installed EasyTag today and edited some .opus tags. Afterwards around half of my files were irreversibly corrupted with stutters, missing segments, etc. Not sure how best to help but the bug is serious so I would have expected Gentoo to at least issue a warning. Thanks.
Comment 6 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-07-06 22:00:22 UTC
I can't see any evidence of something changing here, but I see opensuse rebased their patch at least:
```
-------------------------------------------------------------------
Wed Feb 28 10:00:18 UTC 2024 - Dominique Leuenberger <dimstar@opensuse.org>

- Update to version 2.4.3+155:
  + Port to using libsoup for CDDB requests.
  + Use GSubprocess instead of g_spawn_async().
  + Updated translations.
- Add easytag-taglib-2.0.patch: Fix build against taglib 2.0.
- Rebase easytag-revert-open-handle-ogg.patch.
```

I think they took a snapshot then updated the patch. We could try that, I guess, although easytag looks like a mess still (no new release).