616742 – =net-misc/tigervnc-1.7.1-r2 USE=nls implicit dependencies

Bug 616742 - =net-misc/tigervnc-1.7.1-r2 USE=nls implicit dependencies

Summary: =net-misc/tigervnc-1.7.1-r2 USE=nls implicit dependencies

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	otakuto.gentoo

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2017-04-27 15:46 UTC by Jeroen Roovers (RETIRED)
Modified:	2017-04-28 07:11 UTC (History)
CC List:	2 users (show)

See Also:	610576
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jeroen Roovers (RETIRED) gentoo-dev

2017-04-27 15:46:24 UTC

commit 5355343f4b126dde4d42cd5853e1f5d712496a0a
Author: Alice Ferrazzi <alicef@gentoo.org>
Date:   Thu Apr 27 07:00:46 2017 +0100

    net-misc/tigervnc: added nls use flag bug #610576
    added new maintainer

    Package-Manager: portage-2.3.0

That's a pretty bad commit. Not only does it combine distinct changes (in metadata.xml and the ebuild), but it commits a non-trivial change directly to the stable ebuild. The change should have been committed to a new revision.

The functional part of the commit adds an implicit dependency on sys-devel/gettext and virtual/libiconv.

Comment 1 Alice Ferrazzi Gentoo Infrastructure

2017-04-27 16:10:42 UTC

ah you are right, my fault.

Comment 2 Alice Ferrazzi Gentoo Infrastructure

2017-04-27 16:19:22 UTC

I reverted nls changes of the previous bug.
I will re add in a new revision.

Comment 3 Jeroen Roovers (RETIRED) gentoo-dev

2017-04-27 19:42:07 UTC

You forgot to fix this bug. Please read the Summary again.

Comment 4 Jeroen Roovers (RETIRED) gentoo-dev

2017-04-28 07:11:34 UTC

commit 5033cd0db1edb43060fb9e3250fca1f81f867fb4
Author: Jeroen Roovers <jer@gentoo.org>
Date:   Fri Apr 28 09:11:04 2017 +0200

    net-misc/tigervnc: Make USE=nls dependencies conditional (bug #616742).

    Package-Manager: Portage-2.3.5, Repoman-2.3.2