Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 612254 - RESTRICT=binchecks handling and binary (non-ELF/executable) checks
Summary: RESTRICT=binchecks handling and binary (non-ELF/executable) checks
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Core - Ebuild Support (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Portage team
Depends on:
Blocks: 835380
  Show dependency tree
Reported: 2017-03-10 21:32 UTC by SpanKY
Modified: 2022-04-01 14:47 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Note You need to log in before you can comment on or make changes to this bug.
Description SpanKY gentoo-dev 2017-03-10 21:32:06 UTC
while working with a binary package that installs a ton of files, we found that it still continued to install slowly.  turns out it's because pngfix is still run on all the files.

should the pngfix be behind this restrict check as well ?  i'm leaning towards yes ...

--- a/bin/install-qa-check.d/60pngfix
+++ b/bin/install-qa-check.d/60pngfix
@@ -1,6 +1,8 @@
 # Check for issues with PNG files
 pngfix_check() {
+   has binchecks ${RESTRICT} && return
    local pngfix=$(type -P pngfix)
    if [[ -n ${pngfix} ]] ; then
        local pngout=()
Comment 1 Zac Medico gentoo-dev 2017-03-10 21:48:40 UTC
Yeah, binchecks fits well enough I guess. We could always add RESTRICT="pngfix" later if somebody wanted.