while working with a binary package that installs a ton of files, we found that it still continued to install slowly. turns out it's because pngfix is still run on all the files. should the pngfix be behind this restrict check as well ? i'm leaning towards yes ... --- a/bin/install-qa-check.d/60pngfix +++ b/bin/install-qa-check.d/60pngfix @@ -1,6 +1,8 @@ # Check for issues with PNG files pngfix_check() { + has binchecks ${RESTRICT} && return + local pngfix=$(type -P pngfix) if [[ -n ${pngfix} ]] ; then local pngout=()
Yeah, binchecks fits well enough I guess. We could always add RESTRICT="pngfix" later if somebody wanted.
