Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 611756 - dev-lang/rust-bin - add arm support
Summary: dev-lang/rust-bin - add arm support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Keywording (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Rust Project
URL:
Whiteboard:
Keywords: KEYWORDREQ
Depends on:
Blocks:
 
Reported: 2017-03-05 01:18 UTC by Michael Palimaka (kensington)
Modified: 2019-02-16 22:36 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
rust-bin-1.15.1-arm.patch (rust-bin-1.15.1-arm.patch,1.33 KB, patch)
2017-03-05 01:18 UTC, Michael Palimaka (kensington)
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Palimaka (kensington) gentoo-dev 2017-03-05 01:18:07 UTC
Created attachment 465990 [details, diff]
rust-bin-1.15.1-arm.patch

Please review attached patch. Tested on Raspberry Pi 2.
Comment 1 Felix Janda 2017-03-07 16:03:41 UTC
This appears to be a "subbug" of bug 609654.
Comment 3 Michael Lawrence 2017-06-09 01:40:12 UTC
(In reply to Michael Lawrence from comment #2)
> https://static.rust-lang.org/dist/rust-beta-aarch64-unknown-linux-gnu.tar.gz
> 
> ARM 64 while your at it. 
> 
> https://www.rust-lang.org/en-US/other-installers.html#standalone

https://github.com/sakaki-/gentoo-on-rpi3-64bit 

wiliing to test on my RPI3.
Comment 4 tt_1 2017-09-02 18:44:26 UTC
The patch for the ebuild works in terms of downloading the arm binaries from rust upstream and installing them, accordingly to either arm hard float architecture or arm softfloat architecture. 

But do you think it is possible to move this section

 	local postfix
 	use amd64 && postfix=x86_64-unknown-linux-gnu
+	if use arm; then
+		if [[ "$(tc-is-softfloat)" != "no" ]]; then
+			postfix=arm-unknown-linux-gnueabi
+		else
+			postfix=arm-unknown-linux-gnueabihf
+		fi
+	fi
 	use x86 && postfix=i686-unknown-linux-gnu
 	mv "${WORKDIR}/${MY_P}-${postfix}" "${S}" || die

before the invocation of src_unpack in the ebuild? Because due to this, one has to download both flavours of arm binaries, unpack them both and have one of them installed later. Which gives you a working rust, but still, is a bit of a bummer.
Comment 5 tt_1 2017-09-08 17:59:44 UTC
If someone else feels like compiling firefox binaries you'd need armv7-unknown-linux-gnueabihf and not arm-unknown-linux-gnueabihf in rust-bin. Softfloat is not officially supported by mozilla, but fedora seems to have patches for that (mostly skia related)
Comment 6 tt_1 2018-05-14 18:29:23 UTC
I forgot about this and came up with an own approach for hardfloat in the meantime, it can be reviwed here: https://github.com/gentoo/gentoo/pull/8387

Please add a comment if you'd like to see softfloat detection enabled. I mixed your patch in for armv6j* ; but it can't be done for armv7* softfloat, simply because there is no prebuilt rustc available by upstream.
Comment 7 tt_1 2018-06-02 05:43:22 UTC
Bug can be closed, there is a fix in tree now!
Comment 8 Dirkjan Ochtman (RETIRED) gentoo-dev 2018-06-02 11:58:58 UTC
Thank you for all the hard work, and sorry I couldn't review sooner.
Comment 9 Bram Verweij 2019-02-16 11:10:42 UTC
This bug was a keyword request for the arm architecture. It has been put to resolved fixed, even though the rust-bin package is currently not keyworded for arm (it is keyworded for amd64, x86, arm64, and ppc64).

Could it be re-opened?
Comment 10 Georgy Yakovlev archtester gentoo-dev 2019-02-16 22:36:23 UTC
the keywording is happening in https://bugs.gentoo.org/609654

on positive note, you can keyword yourself and use rust-bin on arm, works for me.
it'll get arm keywords eventually I hope.