Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 610996 - >=sci-geosciences/gpsbabel-1.5: Make gui compilation optional
Summary: >=sci-geosciences/gpsbabel-1.5: Make gui compilation optional
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Sci-geo Project
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2017-02-26 14:39 UTC by Mira Ressel
Modified: 2024-09-28 14:02 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch for gpsbabel-1.5.4 ebuild (0001-sci-geosciences-gpsbabel-Add-a-gui-USE-flag.patch,2.78 KB, patch)
2017-02-26 14:57 UTC, Mira Ressel
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mira Ressel 2017-02-26 14:39:48 UTC
Please add a "gui" (or "qt5", or whatever) USE flag to the >=sci-geosciences/gpsbabel-1.5 ebuild. While dev-qt/qtcore:5 is unconditionally needed even for the CLI application, all the other qt dependencies are only required by the GUI.

I don't need the GUI and I'd really like to avoid installing dev-qt/qtwebengine:5, so an USE flag would be great.

No patches should be neccessary; you'll just have to hide the "pushd gui" blocks behind an use conditional.
Comment 1 Mira Ressel 2017-02-26 14:57:46 UTC
Created attachment 465284 [details, diff]
Patch for gpsbabel-1.5.4 ebuild

I've attached an ebuild patch.
Comment 2 Mira Ressel 2017-02-26 15:02:06 UTC
I've verified that gpsbabel indeed compiles without all the dependencies the patch removes; however, I haven't been able to test compilation without dev-qt/qtnetwork. It should work, but please test it before rolling out the patch.
Comment 3 Andreas Sturmlechner gentoo-dev 2017-02-26 15:03:02 UTC
The ebuild did have USE=qt5 previously, but the build system did not seem to properly support that. See also bug 606952
Comment 4 Mira Ressel 2017-02-26 15:12:55 UTC
(In reply to Andreas Sturmlechner from comment #3)
> The ebuild did have USE=qt5 previously, but the build system did not seem to
> properly support that. See also bug 606952

Yes, I've seen that bug. dev-qt/qtcore is indeed needed even by the CLI application (e.g. for XML handling). The rest of QT is only needed for the GUI, though, and I'm under the impression that upstream is aware of this and does not intend to change the situation.
Comment 5 Chris Mayo 2017-02-26 19:42:24 UTC
emerges fine for me with the patch and USE="-gui" and dev-qt/qtcore-5.6.2-r1 the only Qt 5 package installed.
Comment 6 Andreas Sturmlechner gentoo-dev 2017-02-26 23:11:34 UTC
Thanks, fixed in git commit 107e45305f9a333558d96c1305db5a67880c5d44.