Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 610644 - app-emulation/docker-compose: loosen <dev-python/requests-2.12 dependency
Summary: app-emulation/docker-compose: loosen <dev-python/requests-2.12 dependency
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Alex Brandt (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-23 05:33 UTC by gavk
Modified: 2018-01-20 21:04 UTC (History)
8 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch for docker-compose. (fix-request-2.12-requires.patch,1.48 KB, patch)
2017-02-23 05:35 UTC, gavk
Details | Diff
Ebuild (docker-compose-1.11.1-r1.ebuild,2.26 KB, text/plain)
2017-02-23 05:36 UTC, gavk
Details

Note You need to log in before you can comment on or make changes to this bug.
Description gavk 2017-02-23 05:33:57 UTC
Tested build and work with python-request-1.12.5.
Comment 1 gavk 2017-02-23 05:35:11 UTC
Created attachment 464766 [details, diff]
Patch for docker-compose.
Comment 2 gavk 2017-02-23 05:36:23 UTC
Created attachment 464768 [details]
Ebuild

Requested patch attached.
Comment 3 Zac Medico gentoo-dev 2017-07-02 19:43:55 UTC
(In reply to gavk from comment #1)
> Created attachment 464766 [details, diff] [details, diff]
> Patch for docker-compose.

Maybe we can just remove the maximum version restriction entirely. I suspect that upstream is restricting it only for the sake of restricting it.
Comment 4 Zac Medico gentoo-dev 2017-07-02 19:48:51 UTC
Comment on attachment 464768 [details]
Ebuild

For ebuild changes, please attach a unified diff created as follows:

> diff -u docker-compose-1.14.0.ebuild.orig docker-compose-1.14.0.ebuild > docker-compose-1.14.0.ebuild.diff
Comment 5 Benedikt Waldvogel 2017-09-06 15:29:55 UTC
Looks like upstream is restricting it on purpose.

See https://github.com/docker/compose/issues/4431
Comment 6 Zac Medico gentoo-dev 2017-09-06 16:43:53 UTC
The reason given in https://github.com/docker/compose/issues/4431#issuecomment-277846958 is:

> We make a fairly unconventional use of requests (HTTP over UNIX sockets)
> which makes us particularly sensitive to updates of the requests package -
> even when they're just bugfixes.

My feeling is that we should specify the dependency more optimistically, and then react to reports of breakage if and when they arise.
Comment 7 Zac Medico gentoo-dev 2017-09-06 16:58:25 UTC
In https://git.archlinux.org/svntogit/community.git/tree/trunk/PKGBUILD?h=packages/docker-compose we can see that for docker-compose-1.15.0, Arch uses sed to make it a >= dependency as follows:

>  # Remove upper bound on requires
>  sed -i 's/==/>=/g' requirements.txt
>  sed -i "s/, < .*',$/',/" setup.py
Comment 8 Manuel Rüger (RETIRED) gentoo-dev 2018-01-20 21:04:15 UTC
This should  be fixed in docker-compose-1.17.1 and later.