Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 609570 - net-print/cups-filters unneeded dependencies on app-text/poppler
Summary: net-print/cups-filters unneeded dependencies on app-text/poppler
Status: UNCONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Printing Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-16 20:37 UTC by Ostashevskyi Viktor
Modified: 2019-03-20 13:16 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ostashevskyi Viktor 2017-02-16 20:37:44 UTC
Currently ebuild contains following dependency line:

>=app-text/poppler-0.32:=[cxx,jpeg?,lcms,tiff?,utils,xpdf-headers(+)]

However, jpeg and tiff use flag on cups-filter doesn't require app-text/poppler to be built with them.

cups-filters can use libjpeg and tiff for adding support for this image types in its imagetoraster and imagetopdf filters. These filters don't use poppler, they generate pdf directly by generating text PDF commands and embed images in raw format in PDF.

app-text/poppler supports JPEG compression in PDF documents even without jpeg use flag, in such case it uses its internal implementation. tiff use flag in app-text/poppler is used by pdfimages utility for extracting images from PDF file into tiff file.
Comment 1 James Le Cuirot gentoo-dev 2017-09-22 19:55:56 UTC
cups-filter can build without poppler as there is a --disable-poppler option and I tried it. However, I was then unable to print, at least with hpijs. Maybe other drivers would work.

Perhaps you weren't suggesting that poppler can be disabled entirely and were merely referring to the jpeg and tiff flags. Please clarify.
Comment 2 Ostashevskyi Viktor 2017-09-25 09:36:14 UTC
(In reply to James Le Cuirot from comment #1)
> cups-filter can build without poppler as there is a --disable-poppler option
> and I tried it. However, I was then unable to print, at least with hpijs.
> Maybe other drivers would work.
> 
> Perhaps you weren't suggesting that poppler can be disabled entirely and
> were merely referring to the jpeg and tiff flags. Please clarify.

You're absolutely right, I was talking that poppler is pulled with unneeded use-flags.
Comment 3 Andreas Sturmlechner gentoo-dev 2017-12-20 22:53:08 UTC
(In reply to Ostashevskyi Viktor from comment #0)
> app-text/poppler supports JPEG compression in PDF documents even without
> jpeg use flag, in such case it uses its internal implementation.
That at least is not the case. poppler's internal implementation is completely disabled for good reason - it is abandoned for years and a security liability.
Comment 4 Ostashevskyi Viktor 2017-12-21 10:52:31 UTC
(In reply to Andreas Sturmlechner from comment #3)
> (In reply to Ostashevskyi Viktor from comment #0)
> > app-text/poppler supports JPEG compression in PDF documents even without
> > jpeg use flag, in such case it uses its internal implementation.
> That at least is not the case. poppler's internal implementation is
> completely disabled for good reason - it is abandoned for years and a
> security liability.

But, it should be decided via poppler USE-flags. Why should cups-filter require poppler[jpeg]?

Moreover, if poppler internal JPEG implementation is broken and shouldn't be used, then we should remove jpeg flag from poppler completely and make poppler always require virtual/jpeg.
Comment 5 Andreas Sturmlechner gentoo-dev 2018-03-18 15:24:52 UTC
(In reply to Ostashevskyi Viktor from comment #4)
> Moreover, if poppler internal JPEG implementation is broken and shouldn't be
> used, then we should remove jpeg flag from poppler completely and make
> poppler always require virtual/jpeg.
Do you suppose to take away the freedom of Gentoo users to build poppler completely without jpeg support, however stupid that may be? ;)
Comment 6 Ostashevskyi Viktor 2018-03-18 18:41:51 UTC
(In reply to Andreas Sturmlechner from comment #5)
> (In reply to Ostashevskyi Viktor from comment #4)
> > Moreover, if poppler internal JPEG implementation is broken and shouldn't be
> > used, then we should remove jpeg flag from poppler completely and make
> > poppler always require virtual/jpeg.
> Do you suppose to take away the freedom of Gentoo users to build poppler
> completely without jpeg support, however stupid that may be? ;)

No, not in any way. I'm just saying that cups-filter[jpeg] doesn't require poppler[jpeg] (same for tiff).
Comment 7 Ostashevskyi Viktor 2018-03-18 18:43:59 UTC
(In reply to Andreas Sturmlechner from comment #5)
> (In reply to Ostashevskyi Viktor from comment #4)
> > Moreover, if poppler internal JPEG implementation is broken and shouldn't be
> > used, then we should remove jpeg flag from poppler completely and make
> > poppler always require virtual/jpeg.
> Do you suppose to take away the freedom of Gentoo users to build poppler
> completely without jpeg support, however stupid that may be? ;)

And if we talk about poppler alone and we know that internal JPEG support is broken, than poppler[-jpeg] shouldn't enable any JPEG support, and poppler[jpeg] should pull virtual/jpeg.
Comment 8 Ostashevskyi Viktor 2019-03-20 13:16:11 UTC
Any updates?