609306 – =x11-wm/i3-4.13-r1 on musl - emake failed: resolve_tilde.c:28:26: error: use of undeclared identifier 'GLOB_TILDE'

Bug 609306 - =x11-wm/i3-4.13-r1 on musl - emake failed: resolve_tilde.c:28:26: error: use of undeclared identifier 'GLOB_TILDE'

Summary: =x11-wm/i3-4.13-r1 on musl - emake failed: resolve_tilde.c:28:26: error: use ...

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Nelo-T. Wallus (ntnn)

URL:
Whiteboard:
Keywords:	EBUILD, PATCH

Depends on:
Blocks:	musl-porting
	Show dependency tree

Reported:	2017-02-13 23:24 UTC by Johannes Rosenberger
Modified:	2017-07-28 11:36 UTC (History)
CC List:	3 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
build.log (build.log,13.66 KB, text/plain) 2017-02-13 23:25 UTC, Johannes Rosenberger	Details
patch for i3-4.13-r1.ebuild (i3-4.13-r1-r2.ebuild.patch,617 bytes, patch) 2017-02-13 23:28 UTC, Johannes Rosenberger	Details \| Diff
patch for i3-9999.ebuild (i3-9999.ebuild.patch,537 bytes, patch) 2017-02-13 23:30 UTC, Johannes Rosenberger	Details \| Diff
i3 patch from Alpine Linux (i3-4.11-musl.patch,2.42 KB, patch) 2017-02-13 23:31 UTC, Johannes Rosenberger	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Johannes Rosenberger 2017-02-13 23:24:21 UTC

i3 fails to build on musl with the following message:

    ../../i3-4.13/libi3/resolve_tilde.c:28:26: error: use of undeclared identifier 'GLOB_TILDE'
        int res = glob(head, GLOB_TILDE, ((void*)0), &globbuf);

GLOB_TILDE is not included in glob.h from musl but it is in development in upstream[1]. It was actually planned for musl 1.1.16[2].

I tried out the patch from Alpine Linux[3] and it just worked for i3-4.13-r1 and i3-9999 (see ebuild patches).

The i3 upstream is aware of the problem and of the Alpine patch but waits for musl to implement GLOB_TILDE[4].

Shall I create a pull request for the portage tree or the musl overlay on GitHub?


[1]: http://www.openwall.com/lists/musl/2017/01/17/3
[2]: http://wiki.musl-libc.org/wiki/Roadmap
[3]: http://git.alpinelinux.org/cgit/aports/tree/community/i3wm/musl.patch
[4]: https://github.com/i3/i3/pull/1869

Comment 1 Johannes Rosenberger 2017-02-13 23:25:12 UTC

Created attachment 463682 [details]
build.log

Comment 2 Johannes Rosenberger 2017-02-13 23:28:16 UTC

Created attachment 463684 [details, diff]
patch for i3-4.13-r1.ebuild

* include patch for i3
* renamed from *-r1.ebuild to *-r2.ebuild

Comment 3 Johannes Rosenberger 2017-02-13 23:30:15 UTC

Created attachment 463686 [details, diff]
patch for i3-9999.ebuild

* apply patch to i3

Comment 4 Johannes Rosenberger 2017-02-13 23:31:31 UTC

Created attachment 463688 [details, diff]
i3 patch from Alpine Linux

Comment 5 Johannes Rosenberger 2017-02-13 23:43:44 UTC

Here are the updated ebuilds and the patch ready to try in my overlay on GitHub:

https://github.com/jorsn/jorsn-gentoo-musl/tree/master/x11-wm/i3

Comment 6 Nelo-T. Wallus (ntnn) 2017-07-28 11:36:57 UTC

Author: Nelo-T. Wallus <nelo@wallus.de>
Date:   Thu Jul 13 21:17:15 2017 +0200

    x11-wm/i3: Add GLOB_TILDE patch for musl

    Package-Manager: Portage-2.3.6, Repoman-2.3.1
    Closes: https://github.com/gentoo/gentoo/pull/5230