Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 607400 - net-dns/bind-tools-9.11.0_p2 (& 9.10.4_p4) [readline] automagic to libedit
Summary: net-dns/bind-tools-9.11.0_p2 (& 9.10.4_p4) [readline] automagic to libedit
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Christian Ruppert (idl0r)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 633534
  Show dependency tree
 
Reported: 2017-01-27 14:14 UTC by Denis Kaganovich
Modified: 2018-04-19 11:13 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch to add libedit USE flag and explicitly specify readline library (bind-tools-explicit-readline.patch,1.46 KB, patch)
2017-07-11 19:36 UTC, Matt Whitlock
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Denis Kaganovich 2017-01-27 14:14:43 UTC
bind-tools/bind-tools[readline] really don't want strict readline, but try libedit first, readline next. This reflected in configure.in|configure.ac:
"for readline in -ledit -lreadline"
So, if libedit was installed, nslookup & nsupdate (at least) will be linked to libedit automagically (and not readline).
So, on maintainer's select, need to select:
1) remove " -ledit" from configure.in (configure.ac) (simpliest);
2) add "libedit" useflag and dependences, exclusive to readline;
3) something else.

Fastest solution - prepare:
sed -i -e 's: -ledit : :' "${S}"/configure.*


Reproducible: Always

Steps to Reproduce:
1. emerge libedit && USE=readline emerge bind-tools
2. ldd /usr/bin/nslookup|grep libedit
3.
Comment 1 Matt Whitlock 2017-07-11 19:36:10 UTC
Created attachment 483314 [details, diff]
patch to add libedit USE flag and explicitly specify readline library

Attached is a patch implementing OP's alternative #2. This adds a "libedit" USE flag, which is preferred over the existing "readline" USE flag, and explicitly specifies the selected readline implementation in the --with-readline= configure option.

For brevity, the attached patch modifies only the latest version of net-dns/bind-tools, but a similar/identical change should be applied to the ebuilds for the older versions as well.
Comment 2 Larry the Git Cow gentoo-dev 2018-04-19 11:13:51 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=99515b1d62992e0739cc43f7138ff0ba450e80a7

commit 99515b1d62992e0739cc43f7138ff0ba450e80a7
Author:     Craig Andrews <candrews@gentoo.org>
AuthorDate: 2018-03-01 23:30:57 +0000
Commit:     Christian Ruppert <idl0r@gentoo.org>
CommitDate: 2018-04-19 11:11:01 +0000

    net-dns/bind-tools: 9.12.1 version bump
    
    Closes: https://bugs.gentoo.org/649294
    Closes: https://bugs.gentoo.org/607400
    Closes: https://bugs.gentoo.org/633534
    Bug: https://bugs.gentoo.org/649326
    Bug: https://bugs.gentoo.org/592560
    Package-Manager: Portage-2.3.24, Repoman-2.3.6
    Closes: https://github.com/gentoo/gentoo/pull/7330

 net-dns/bind-tools/Manifest                 |   1 +
 net-dns/bind-tools/bind-tools-9.12.1.ebuild | 143 ++++++++++++++++++++++++++++
 2 files changed, 144 insertions(+)