Bug 606784 – =app-misc/gcstar-1.7.1 version bump

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Giuseppe Foti 2017-01-22 08:54:43 UTC]

Created attachment 460944 [details]
just worked on my system, no more test done

http://forums.gcstar.org/viewtopic.php?id=18101
http://www.gcstar.org/index.en.php

[Comment 1 Jonas Stein 2017-01-22 21:07:27 UTC]

thank you for your contribution.

I had a short look ad the ebuild. Here my suggestions:

* always try to use the most recent EAPI.

* There is a "ebuild-checker" which can show several common mistakes in ebuilds.
You start it with repoman -d full 

* remove some of the empty lines obsolete code like
#	epatch "${FILESDIR}/${P}-gcstar.desktop.patch"

* A for loop like

for size in 16 22 24 32 36 48 64 72 96 128 256
	do
		insinto /usr/share/icons/hicolor/${size}x${size}/apps
		newins share/gcstar/icons/gcstar_${size}x${size}.png gcstar.png
	done


is often used, but as far I know it is superseded by 
doicon and newicon
https://devmanual.gentoo.org/eclass-reference/eutils.eclass/

[Comment 2 Harald Weiner 2017-03-13 15:22:58 UTC]

Created attachment 466892 [details]
app-misc/gcstar-1.7.1.ebuild

[Comment 3 Harald Weiner 2017-03-13 15:24:16 UTC]

Dear all, I have attached an updated version of the ebuild, based on the contribution by Giuseppe.

[Comment 4 Jonas Stein 2017-12-05 10:41:09 UTC]

@Alexandre did you already review the ebuild? 
Do you still have the time to maintain this package?

[Comment 5 Alexandre Rostovtsev (RETIRED) 2018-03-23 21:27:46 UTC]

Fixed; thanks to Giuseppe, Jonas, and Harald for the ebuild and comments. I apologize for the unacceptably long delay in addressing this.

commit 687e0c4fb428289dca2ea45f1459025da242bea6
Author: Alexandre Rostovtsev <[e-mail]>
Date:   Fri Mar 23 17:21:43 2018 -0400

    app-misc/gcstar: belated version bump to 1.7.1 - bug #606784