Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 606704 - dev-python/sip-4.19 fix invalid member bug
Summary: dev-python/sip-4.19 fix invalid member bug
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Qt Bug Alias
URL:
Whiteboard:
Keywords: PATCH, UPSTREAM
: 604472 606968 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-01-21 14:38 UTC by Alex Turbov
Modified: 2017-02-19 01:44 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
patch to fix the sip bug (sip-4.19-fix-missed-member.patch,308 bytes, patch)
2017-01-21 14:39 UTC, Alex Turbov 		Details | Diff
sip-4.19-changeset-1611-1618.patch (sip-4.19-changeset-1611-1618.patch,2.89 KB, patch)
2017-02-13 10:56 UTC, Fabio Rossi 		Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Turbov 2017-01-21 14:38:29 UTC 
the patch attached is fixing the compilation error:

error: 'sipWrapperType {aka struct _sipWrapperType}' has no member named 'type'
     return (sipClass ? sipClass->type : 0);

Need to add it to `PATCHES` array

Reproducible: Always
Comment 1 Alex Turbov 2017-01-21 14:39:06 UTC 
Created attachment 460834 [details, diff]
patch to fix the sip bug
Comment 2 Davide Pesavento gentoo-dev 2017-01-22 18:01:11 UTC 
This should go upstream.
Comment 3 Alex Turbov 2017-01-23 00:29:22 UTC 
sure! I've sent a patch to upstream's ML, but before it reach upstream, what should I do? I have a compile error with another packet using SIP 4.19 because of this bug...
Comment 4 Davide Pesavento gentoo-dev 2017-01-23 01:17:10 UTC 
What package?

You can use this method https://wiki.gentoo.org/wiki//etc/portage/patches in the meantime.
Comment 5 Davide Pesavento gentoo-dev 2017-01-31 16:53:32 UTC 
(In reply to Alex Turbov from comment #3)
> sure! I've sent a patch to upstream's ML

Any updates? I don't see your email in the ML archives...
Comment 6 Alex Turbov 2017-01-31 17:35:06 UTC 
(In reply to Davide Pesavento from comment #5)
> (In reply to Alex Turbov from comment #3)
> > sure! I've sent a patch to upstream's ML
> 
> Any updates? I don't see your email in the ML archives...

I'm not in the list, so probably my mail still waits a confirmation...
Comment 7 Davide Pesavento gentoo-dev 2017-01-31 17:43:41 UTC 
I think you need to sign up then, or your emails will simply go to /dev/null
Comment 8 Fabio Rossi 2017-02-13 10:56:52 UTC 
Created attachment 463594 [details, diff]
sip-4.19-changeset-1611-1618.patch

A few patches have been inserted upstream, see https://www.riverbankcomputing.com/pipermail/pyqt/2017-February/038822.html, I have attached the full patch here for convenience
Comment 9 Fabio Rossi 2017-02-13 10:58:14 UTC 
*** Bug 606968 has been marked as a duplicate of this bug. ***
Comment 10 Fabio Rossi 2017-02-13 10:58:51 UTC 
*** Bug 604472 has been marked as a duplicate of this bug. ***
Comment 11 Jouni Kosonen 2017-02-18 13:51:13 UTC 
(In reply to Fabio Rossi from comment #8)
Nice! 

As far as I can tell that patch ended up in sip-4.19.1. Can you verify?
Comment 12 Davide Pesavento gentoo-dev 2017-02-19 01:44:10 UTC 
I just bumped sip-4.19.1 which fixes this bug. Thanks!

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=18859f5f089666dcf3b021abb65bfd9b171ddc7c