Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 604084 - sys-devel/gcc-5.4.0-r2 has deceitful ${PV}
Summary: sys-devel/gcc-5.4.0-r2 has deceitful ${PV}
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: Gentoo Toolchain Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-29 21:44 UTC by Arfrever Frehtes Taifersar Arahesis
Modified: 2023-09-28 12:00 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis 2016-12-29 21:44:10 UTC
sys-devel/gcc-5.4.0 was released by upstream on 2016-06-03.

sys-devel/gcc-5.4.0-r2 was added in:
https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=44fcc2bf597681696a071f80cfba1279494d5294

sys-devel/gcc-5.4.0-r2 is actually a snapshot from 2016-12-27 masqueraded as new revision of sys-devel/gcc-5.4.0.

sys-devel/gcc-5.4.0-r2 uses gcc-5.4.0-patches-1.2.tar.bz2 which contains patch/95_all_gcc5-head-snapshot-diff-20161227.patch (with size about 9.3 MiB) whose header is:
"""
This patch include alot of patches and fixes.
The patch snapshot is taken with
git diff 32c3b88e8ced4b6d022484a73c40f3d663e20fd4 > file
on the gcc 5 branch. I meens that it include all fixes that is
commited from the relese date and to current day. 20161227
https://gcc.gnu.org/bugzilla/buglist.cgi?bug_status=RESOLVED&resolution=FIXED&target_milestone=5.5
"""

I think that snapshots are acceptable, but they must have proper ${PV} (e.g. *_pre${DATE} or *_p${DATE}).

I suggest to use PV = 5.4.1_p20161227. It will need small changes in toolchain.eclass.
5.4.1 is current value in gcc/BASE-VER in gcc-5-branch:
https://gcc.gnu.org/viewcvs/gcc/branches/gcc-5-branch/gcc/BASE-VER?revision=237059&view=markup
(Change of gcc/BASE-VER is currently skipped in gcc-5.4.0-patches-1.2.tar.bz2:patch/95_all_gcc5-head-snapshot-diff-20161227.patch as workaround for bug #603798. After proper fixing of toolchain.eclass, ${PV} starting with 5.4.1 should be useable.)

Upstream provides some snapshots in ftp://gcc.gnu.org/pub/gcc/snapshots/ so it might be better to use these snapshots instead of adding a large patch to Gentoo patchset for GCC.
Comment 1 SpanKY gentoo-dev 2016-12-29 22:27:25 UTC
i'm inclined to just mask/delete it.  we stopped doing snapshots of gcc by design -- it's too much of a hassle to track stability.
Comment 2 Thomas Deutschmann (RETIRED) gentoo-dev 2016-12-29 22:33:43 UTC
The package was rev bumped to fix bug 586052 which blocked gcc-5.4 stabilization.

If we are going to drop gcc-5.4.0-r2 please decide if the bug above still blocks stabilization of gcc-5.4 on Gentoo. If not, we will start stabilization of =sys-devel/gcc-5.4.0 immediately which we have been waiting for a long time. Or tell us if you are going to add just a small patch to address the issue from that bug so we can finally move on.
Comment 3 Matt Whitlock 2016-12-29 22:41:36 UTC
(In reply to Thomas Deutschmann from comment #2)
> The package was rev bumped to fix bug 586052

It looks like the patchset includes a lot more than just the fix for bug 586052.

Perhaps 5.4.0-r2 should _only_ fix the -Wunused-* bug.
Comment 4 SpanKY gentoo-dev 2016-12-29 23:00:18 UTC
(In reply to Thomas Deutschmann from comment #2)

doing a snapshot to pick up a 2 line patch makes absolutely no sense
Comment 5 Thomas Deutschmann (RETIRED) gentoo-dev 2016-12-29 23:04:01 UTC
I agree. Maybe Magnus can explain his decision.
Comment 6 SpanKY gentoo-dev 2016-12-29 23:40:34 UTC
(In reply to Thomas Deutschmann from comment #5)

right -- i don't like reverting people's work w/out getting their input first
Comment 7 Magnus Granberg gentoo-dev 2017-01-01 23:17:32 UTC
(In reply to SpanKY from comment #6)
> (In reply to Thomas Deutschmann from comment #5)
> 
> right -- i don't like reverting people's work w/out getting their input first

Was not for picking up a 2 line patch that i made a snapshot.
Was to fix over 30 ICE/Regression that will fixed in 5.5
https://gcc.gnu.org/bugzilla/buglist.cgi?bug_status=RESOLVED&resolution=FIXED&target_milestone=5.5
I could have pick all as separated patched but that was alot of work.
Do what you want i done with toolchain.
Comment 8 Matt Whitlock 2017-01-02 04:47:58 UTC
(In reply to Magnus Granberg from comment #7)
> Was not for picking up a 2 line patch that i made a snapshot.
> Was to fix over 30 ICE/Regression that will fixed in 5.5

Maybe this is fine, though it should have warranted a 5.5.0_pre2016xxxx PV rather than masquerading as a rev bump.
Comment 9 Anton Bolshakov 2017-01-03 07:02:03 UTC
(In reply to Magnus Granberg from comment #7)
> Do what you want i done with toolchain.

I'm testing and waiting for GCC stabilization too and was disappointed with this is quite a bazaar comment.  Gentoo is not "do what you want". There are policies which everybody should follow. Remove yourself from Maintainers if you lost an interest.

This -r2 release with massive set of the latest and greatest patches is not acceptable simply because it might introduce other bugs and we will go to wishes circle.

To the rest: you should probably create a usual [tracker] bug for GCC 5 stabilisation and block it with specific bugs.
Comment 10 Magnus Granberg gentoo-dev 2017-02-04 20:56:40 UTC
gcc-5.4.0-r2 is removed from the tree