Bug 60345 – Packages with bad patches

• Status: RESOLVED LATER
• Product: Gentoo Linux

[Description Chris White (RETIRED) 2004-08-14 09:47:23 UTC]

Did a full repoman on the tree last night with the the epatch repoman
check mentioned in Bug #59902.  Results will be attached in just a second.
I'll try and sort this all into the appropriate herds once I do some much 
needed version bumping.

[Comment 1 Chris White (RETIRED) 2004-08-14 09:48:19 UTC]

Created attachment 37432 [details]
Output on repoman's check on bad patches

[Comment 2 Chris White (RETIRED) 2004-08-14 12:10:27 UTC]

Adding cc's for relevant herds/maintainers, please check the attached file
for the packages listed under your email:

[e-mail] - emacs
[e-mail] - poedit
[e-mail] - openoffice
[e-mail] - singular
[e-mail] - zsh
[e-mail] - tetex
[e-mail] - libpqpp
[e-mail] - mysql mysql++ (needs metadata.xml as well)
[e-mail] - pwlib
[e-mail] - cmucl/-source
[e-mail] - libperl and mod_perl
[e-mail] - PyQT
[e-mail] - netris
[e-mail] - kdebase
[e-mail] - pine
[e-mail] - gnuplot
[e-mail] - xv (needs metadata.xml as well)
[e-mail] - streamripper
[e-mail] - xawtv
[e-mail] - nvidia-glx
[e-mail] - snort
[e-mail] - l2tpd and rp-l2tp
[e-mail] - eggdrop
[e-mail] - netsed
[e-mail] - middleman
[e-mail] - mod_auth_external
[e-mail] - busybox
[e-mail] - lwp
[e-mail] - windowmaker

[Comment 3 SpanKY 2004-08-14 12:19:59 UTC]

sounds like your patch needs work

netris is a false positive

[Comment 4 SpanKY 2004-08-14 12:20:27 UTC]

as is streamripper

[Comment 5 Sven Wegener 2004-08-14 12:25:36 UTC]

Removing net-irc as the epatch'es in net-irc/eggdrop are false positives.
The patch files are extracted and applied in src_unpack().

[Comment 6 solar (RETIRED) 2004-08-14 12:29:25 UTC]

I can't reproduce your problem on my local end with middleman. Are you sure your checks are right?

[Comment 7 solar (RETIRED) 2004-08-14 12:31:15 UTC]

I think the same for busybox. I've merge this no less than 2-3 times a week

[Comment 8 Rob Cakebread (RETIRED) 2004-08-14 12:33:09 UTC]

Removed python@g.o., PyQt was a false positive, removed liquidx (I fixed wxwindows herd epatch in poedit)

[Comment 9 Tuan Van (RETIRED) 2004-08-14 14:03:45 UTC]

remove net-mail, pine fixed.

[Comment 10 Stefan Knoblich (RETIRED) 2004-08-14 14:16:31 UTC]

pwlib fixed, thx

[Comment 11 Robin Johnson 2004-08-14 14:50:17 UTC]

your patch needs work still.
Eg it complained at this, in mysql-4.0.15-r1:
[ "$PV" == "4.0.14" ] &&
epatch ${FILESDIR}/mysql-${PV}-security-28394.patch

Yes there is no line continuation, but it is still perfectly valid with any line continuation character.

MySQL++ is fixed.

[Comment 12 Andrew Bevitt 2004-08-14 15:13:29 UTC]

Removing xfree nvidia-glx is false positive.

[Comment 13 SpanKY 2004-08-14 16:06:21 UTC]

next time review the data before making maintainers waste their time ... theres way too many false positives here for the scan to be useful i think