Bug 603372 – x11-misc/virtualgl: init script should use checkpath instead of truncate/chmod

• Status: CONFIRMED
• Product: Gentoo Linux

[Description Michael Orlitzky 2016-12-21 19:49:59 UTC]

The init script for vgl used "truncate" and "chmod" to create an empty file with mode 644:

  start() {
      ebegin "Starting VirtualGL"
      truncate --size=0 /var/lib/VirtualGL/vgl_xauth_key
      ...
      xauth -f /var/lib/VirtualGL/vgl_xauth_key add $DISPLAY . \
        $(xauth -f $XAUTHORITY list | awk '{print $3;exit}') && \
        chmod 644 /var/lib/VirtualGL/vgl_xauth_key
      eend $?
  }

A single call to "checkpath" from OpenRC (man openrc-run) would be more appropriate here. It's more portable, being part of OpenRC, and it's also more secure: truncate and chmod will follow symlinks, so if root:root ever loses full control of that path, somebody might be able to swap out that auth file for a symlink and gain root.

[Comment 1 Pacho Ramos 2023-04-17 13:30:14 UTC]

I cannot test it on openRC... but feel free to go ahead if it works for you

Thanks