Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 60293 - xorg-x11 copies conf files from build system, not install system, which breaks binaries
Summary: xorg-x11 copies conf files from build system, not install system, which break...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Gentoo X packagers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 60292
  Show dependency tree
 
Reported: 2004-08-13 23:35 UTC by Donnie Berkholz (RETIRED)
Modified: 2004-08-21 22:53 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Donnie Berkholz (RETIRED) gentoo-dev 2004-08-13 23:35:22 UTC
xorg.conf and other files are copied into the build in src_install(). If a package is built on machine 1 and installed on machine 2, this will result in the conf file being updated, then transferred from 1 to 2, rather than the one from 2 being updated.

The goal is to do this updating in a way that allows etc-update to be used to merge the new changes. Therefore, it needs to be done in or prior to src_install(). The only function relevant only to the install machine that meets those conditions is pkg_setup(). (Although that may not even be run for binary installs -- see http://bugs.gentoo.org/show_bug.cgi?id=58526#c19 and http://bugs.gentoo.org/show_bug.cgi?id=25152.)

For this to work optimally, pkg_setup() MUST be run for binary installs. Other options include:
1) Hacking it directly on the live filesystem, without allowing etc-update. This sucks because it takes the choice away from the user.
2) Not hacking it at all and just having some einfo. This will break people's systems if they don't read einfo (which, of course, everyone reads).
Comment 1 Donnie Berkholz (RETIRED) gentoo-dev 2004-08-13 23:37:59 UTC
Also, note that a sed into ._cfg0001_xorg.conf and friends is broken. This assumes the user always runs etc-update so cfg000{2,3,...} don't exist. If this needs to be done, the filesystem will have to be checked for the highest number in the cfgXXXX, then add a new file one higher.
Comment 2 Donnie Berkholz (RETIRED) gentoo-dev 2004-08-21 22:53:23 UTC
Fixed in 6.7.99.902