Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 602404 - mail-client/balsa-2.5.3 version bump
Summary: mail-client/balsa-2.5.3 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-12 00:58 UTC by Jack
Modified: 2017-07-24 08:37 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
patch for ebuild against current version (balsa_ebuild_2.5.3.patch,1.40 KB, patch)
2016-12-12 00:59 UTC, Jack
Details | Diff
proposed ebuild (balsa-2.5.3.ebuild,2.71 KB, text/plain)
2016-12-12 01:00 UTC, Jack
Details
Patch to configure.ac to allow balsa to work with >=gpgme-1.8 (balsa_gpgme18.patch,967 bytes, patch)
2016-12-15 22:46 UTC, Jack
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jack 2016-12-12 00:58:23 UTC
New version just released.  From the email notice:

balsa-2.5.3 has been released.

This release is an outcome of continued Peter Bloomfield's work, who has been updating the code to keep it up to date with gtk and other library changes. He implemented many improvents - the full list in the ChangeLog. Albrecht Dreß contributed Osmo address book support, GCR support for displaying a certificate widget, PGP improvements, aUTH PLAIN SASL mechanism for POP3, cleaned up threads and dropped old cruft that we colleced over the years.

I've modified the 2.5.2-r1 ebuild, but someone should obviously check it carefully.  I bumped the dep versions for glib and gtk+:3, as well as commented out (should be removed if confirmed) which seem no longer needed.  I also added --with-osmo to the configure call, but that should either be dropped or matched with a use flag - but the version of osmo required is not released and so not in portage.  My assumption is that it will simply not be found for a user who doesn't have it.

I noticed the build still applies some patches - but I don't know where they are coming from, but I assume it is from the "inherit gnomes".

I'll attach both the ebuild and the diff from the current one.
Comment 1 Jack 2016-12-12 00:59:27 UTC
Created attachment 455956 [details, diff]
patch for ebuild against current version
Comment 2 Jack 2016-12-12 01:00:18 UTC
Created attachment 455958 [details]
proposed ebuild
Comment 3 Jack 2016-12-15 22:46:11 UTC
Created attachment 456342 [details, diff]
Patch to configure.ac to allow balsa to work with  >=gpgme-1.8

gpgme-1.8 is thread-safe, so it no longer includes a gpgme-pthreads so file.  The patch (from upstream balsa, pulled from a git commit) allows balsa to do the right thing if gpgme is 1.8 or above.  Note this also requires an epatch line added to the ebuild.  I'll be glad to update the ebuild and patch, if desired.
Comment 4 Mart Raudsepp gentoo-dev 2016-12-18 17:22:34 UTC
I'm not sure why we (gnome@) still maintain this. Looks like it was a historical thing ever since 2002-2004 that gnome@ maintained. Nowadays we have plenty already with evolution.
Would you (Jack) consider proxy maintaining it completely together with gentoo proxy maintainers project instead for the long term, or does anyone in GNOME team have continued interest in this?
Comment 5 Jack 2016-12-18 17:31:39 UTC
It's still nominally a gnome project, although admittedly not a core part of gnome.  I will proxy maintain to avoid maintainer needed, but I'll certainly need help with proper ebuilds.

One new thing about this ebuild - for this release, the gtk3 branch has become master, so the gtk depends needs to change.  I'll try to do that in the next days (too much real life this weekend.)
Comment 6 Pacho Ramos gentoo-dev 2017-01-15 16:46:41 UTC
(In reply to Jack from comment #3)
> Created attachment 456342 [details, diff] [details, diff]
> Patch to configure.ac to allow balsa to work with  >=gpgme-1.8
> 
> gpgme-1.8 is thread-safe, so it no longer includes a gpgme-pthreads so file.
> The patch (from upstream balsa, pulled from a git commit) allows balsa to do
> the right thing if gpgme is 1.8 or above.  Note this also requires an epatch
> line added to the ebuild.  I'll be glad to update the ebuild and patch, if
> desired.

Do you have the references for this? I see this is not being applied in other distros even running that gpgme version

Thanks
Comment 7 Jack 2017-01-19 22:37:14 UTC
I haven't been able to find a definitive reference yet, but this change was also made for KMyMoney.  The problem will start to be seen in more applications, as gpgme-1.8, being thread safe, doesn't require the use of gpgmepp (or some variant) so an old build system would fail looking for an unneeded gpgmepp.  (I think there was also another failure indicative of the same thing, but my memory is failing to dredge up the details.)

https://git.reviewboard.kde.org/r/129371/#review100789 is where it was done for KMyMoney, but that actually originated for a slightly different issue, so I'm not sure how obvious it is for this problem.  However, this review request was opened by ASturm (Gentoo KDE developer) so perhaps he can point to the appropriate justification.
Comment 8 Jack 2017-01-27 21:00:26 UTC
If there is still a question about the gpg stuff, I'd rather drop that patch and deal with it later as a revision or patch release, just so this version gets released before a new version comes out.
Comment 9 Pacho Ramos gentoo-dev 2017-01-31 21:31:23 UTC
personally I would try to get the patch upstreamed... as it seems it was coming from there... can't we simply wait for the next balsa version? Or is it broken on a hard way? (it seems other distributions are not needing to patch it just now even running with newer gpgme versions)
Comment 10 Jack 2017-01-31 22:13:53 UTC
I got that patch from them.  It's already in their git master.  I just don't know how soon they will make another release.  I'd rather go with the current release without that patch than to wait.  

I've already forgotten the details - but I don't think balsa will fail with gpgme-1.8, as long as it can also find the thread-safe call it used previously (from a vague memory, something like libpthread, but I'm really not sure.)
Comment 11 Jack 2017-07-23 16:07:15 UTC
Although I'm currently running Balsa compiled from git, it looks like I see 2.5.3 in portage.  If I'm not seeing things, does that mean this request can be closed?