Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 601514 - sys-block/open-iscsi-[2.0.873-r2, 2.0.874] should not insist upon "re-set to defaults"
Summary: sys-block/open-iscsi-[2.0.873-r2, 2.0.874] should not insist upon "re-set to ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-03 13:02 UTC by Manfred Knick
Modified: 2017-06-18 21:26 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info sys-block/open-iscsi > 0_open-iscsi_emerge-info.txt (0_open-iscsi_emerge-info.txt,5.61 KB, text/plain)
2016-12-04 11:23 UTC, Manfred Knick
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Manfred Knick 2016-12-03 13:02:29 UTC
current: sys-block/open-iscsi-2.0.873-r2

After each emerge -u:

* IMPORTANT: config file '/etc/iscsi/initiatorname.iscsi' needs updating.

The corresponding

. . . /etc/iscsi/._cfg0000_initiatorname.iscsi

requests to override any user-defined initiator name
by the installation default of the package.

This has to be rejected / deleted @ every update again and again.

Thanks.

--

uname -a:
Linux sid 4.4.35-gentoo #1 SMP Sun Nov 27 15:47:53 CET 2016 x86_64 Intel(R) Xeon(R) CPU E3-1276 v3 @ 3.60GHz GenuineIntel GNU/Linux

Any additional / specific info that could be helpful?
Comment 1 Jonas Stein gentoo-dev 2016-12-03 21:05:47 UTC
yes, I assign the bug, but please add emerge --info and the .log in the meantime.
Comment 2 Manfred Knick 2016-12-04 11:23:05 UTC
Created attachment 455056 [details]
emerge --info sys-block/open-iscsi > 0_open-iscsi_emerge-info.txt
Comment 3 Manfred Knick 2016-12-04 11:33:11 UTC
(In reply to Jonas Stein from comment #1)
> yes, I assign the bug, 
Thanks, Jonas!
> but please add emerge --info 
Done.
> and _the_ .log    <--- ?
Build && Install both run successfully --> no ".log" in /var/log/portage/
> in the meantime.

Kind regards
Comment 4 Manfred Knick 2017-06-17 13:50:51 UTC
It's now sys-block/open-iscsi-2.0.874 inb between.

sys-block/open-iscsi/open-iscsi-2.0.874.ebuild,

function src_install(),

lines 94 / 95:

    insinto /etc/iscsi
    newins "${FILESDIR}"/initiatorname.iscsi initiatorname.iscsi.example

.........................^^^^^^^^^^^^^^^^^^^

installs _un_conditionally,
without checking if a (custom adjusted) version already exists.
Comment 5 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2017-06-18 03:32:46 UTC
Hmm, at some point, upstream decided to ship their own /etc/iscsi/initiatorname.iscsi, but the ebuild was never properly updated for that.

Fixed now in 2.0.874-r1.

[master 909dc831cc0] sys-block/open-iscsi: prevent endless changes of /etc/iscsi/initiatorname.iscsi.
 Date: Sat Jun 17 20:28:05 2017 -0700
 1 file changed, 121 insertions(+)
 create mode 100644 sys-block/open-iscsi/open-iscsi-2.0.874-r1.ebuild
Comment 6 Manfred Knick 2017-06-18 08:17:27 UTC
HINT:   Even IF upstream WERE deterministic:

According to RFC 3720,
any project setup is free to choose its iSCSI Qualified Names (IQN) along
   literal iqn
   date
   authority
   Optional ":" prefixing a storage target name
which must not be overwritten at (even minor) release updates.

Thanks for applying your change!


Concerning

   HOMEPAGE="https://github.com/open-iscsi/open-iscsi"
           # http://www.open-iscsi.com is dead            <-----

please note

. . . [ http://scst.sourceforge.net ]


PROPOSAL:

   HOMEPAGE="http://scst.sourceforge.net"
            "https://github.com/open-iscsi/open-iscsi"
Comment 7 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2017-06-18 19:12:31 UTC
(In reply to Manfred Knick from comment #6)
> Concerning
> 
>    HOMEPAGE="https://github.com/open-iscsi/open-iscsi"
>            # http://www.open-iscsi.com is dead            <-----
scst != open-iscsi.

If you look at the GitHub page, it doesn't mention SCST at all.
Comment 8 Manfred Knick 2017-06-18 20:21:13 UTC
(In reply to Robin Johnson from comment #7)
> (In reply to Manfred Knick from comment #6)

> scst != open-iscsi.
You are perfectly right - I apologize mixing things up
(too many roads under simultaneous consideration).

Correcting myself:

-->  http://www.open-iscsi.com/                    points to
     https://github.com/open-iscsi/                points to
     https://github.com/open-iscsi/open-iscsi      finally.

Intended PROPOSAL:

   HOMEPAGE="http://www.open-iscsi.com"
            "https://github.com/open-iscsi/open-iscsi"

so a novice gets pointed to the "Introduction" first.

--

"Replace open-iscsi.org with open-iscsi.com"

[ https://github.com/open-iscsi/open-iscsi/
          commit/888ee69f17ad0faaee90aafcca25ec8942e9d293 ]
Comment 9 Manfred Knick 2017-06-18 21:26:39 UTC
Cross-Reference:

Bug 575268 - sys-block/open-iscsi: "update HOMEPAGE/SRC_URI to github"

https://bugs.gentoo.org/show_bug.cgi?id=575268#c4