Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 601434 - mail-filter/rspamd: multiple bundled libraries, bundled libs not included in LICENSE yet
Summary: mail-filter/rspamd: multiple bundled libraries, bundled libs not included in ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Christian Roessner
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: bundled-libs
  Show dependency tree
 
Reported: 2016-12-02 11:08 UTC by Michał Górny
Modified: 2020-03-14 12:07 UTC (History)
6 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2016-12-02 11:08:12 UTC
Looking through the build log, I suspect the following libraries are bundled:

- dev-libs/hiredis
- app-arch/zstd
- https://github.com/nmathewson/libottery [not packaged?]
- https://github.com/Cyan4973/xxHash
- ...

Looks like pretty much the whole contrib/ are purely bundled libraries, and upstream doesn't understand what 'contrib' is about.
Comment 1 Dirkjan Ochtman (RETIRED) gentoo-dev 2016-12-02 12:49:11 UTC
I've pushed back about it a bit already, but he keeps adding more stuff. At least for hiredis, there were a bunch of ugly bugs in the later versions, so bundling something known to work was sane.

For zstd, AIUI the API is not stable yet?

I will look into it more, but I doubt it's feasible to unbundle everything.
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2016-12-02 13:07:33 UTC
Can't help you much here. However, I don't see why we shouldn't use the libraries Gentoo provides if they match the program, even if upstream doesn't consider them stable long-term.
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2016-12-02 13:07:53 UTC
Also, if you bundle libraries, make sure to list all their licenses in LICENSE.
Comment 4 Jonas Stein gentoo-dev 2020-02-04 01:39:30 UTC
Please go through the bundled libs and add the proper licenses, if they are missing as said.
Comment 5 Larry the Git Cow gentoo-dev 2020-03-14 12:07:06 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=845424895d1aac6bb80f62d2f7a579e257c7eef6

commit 845424895d1aac6bb80f62d2f7a579e257c7eef6
Author:     Petr Vaněk <arkamar@atlas.cz>
AuthorDate: 2020-03-09 10:28:27 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2020-03-14 12:06:54 +0000

    mail-filter/rspamd: add licenses of bundled libraries
    
    Closes: https://bugs.gentoo.org/601434
    Package-Manager: Portage-2.3.89, Repoman-2.3.20
    Signed-off-by: Petr Vaněk <arkamar@atlas.cz>
    Closes: https://github.com/gentoo/gentoo/pull/14895
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 mail-filter/rspamd/rspamd-2.1.ebuild  | 2 +-
 mail-filter/rspamd/rspamd-2.2.ebuild  | 2 +-
 mail-filter/rspamd/rspamd-2.3.ebuild  | 2 +-
 mail-filter/rspamd/rspamd-2.4.ebuild  | 2 +-
 mail-filter/rspamd/rspamd-9999.ebuild | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)