Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 601048 - net-p2p/deluge-1.3.13-r1 stable request
Summary: net-p2p/deluge-1.3.13-r1 stable request
Status: RESOLVED DUPLICATE of bug 530720
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Stabilization (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Paolo Pedroni
URL:
Whiteboard:
Keywords: STABLEREQ
Depends on: 530720
Blocks:
  Show dependency tree
 
Reported: 2016-11-28 05:29 UTC by Diogo Pereira
Modified: 2017-02-03 11:38 UTC (History)
2 users (show)

See Also:
Package list:
net-p2p/deluge-1.3.13-r1
Runtime testing required: Yes


Attachments
0002-net-p2p-deluge-Fix-dependency-on-net-libs-rb_libtorr.patch (0002-net-p2p-deluge-Fix-dependency-on-net-libs-rb_libtorr.patch,2.87 KB, patch)
2016-12-15 10:48 UTC, Paolo Pedroni
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diogo Pereira 2016-11-28 05:29:38 UTC
Please stabilize.
Comment 1 Paolo Pedroni 2016-11-28 10:53:22 UTC
Fine for me. Only problem is that rb_libtorrent-1.0.10 is not stable. I'm quite sure we can change back the dependency to >=net-libs/rb_libtorrent-0.16.17 without any ill effects.

Kristian, do you want a patch, or is it trivial enough and you can do it on your own?
Comment 2 Kristian Fiskerstrand (RETIRED) gentoo-dev 2016-11-28 11:49:05 UTC
(In reply to Paolo Pedroni from comment #1)
> Fine for me. Only problem is that rb_libtorrent-1.0.10 is not stable. I'm

Is there a problem with making it stable as part of the process? 

> quite sure we can change back the dependency to
> >=net-libs/rb_libtorrent-0.16.17 without any ill effects.

keep in mind that such a change will restart the count of package in ~arch for 30 days before stabilization so you might want to consider option #1 above.
> 
> Kristian, do you want a patch, or is it trivial enough and you can do it on
> your own?

If going this route; patch please :) (remember to revbump)

NB! I've run into certain issues with configuration getting lost on update and difficulties starting deluged (it is OK from the web interface, but not from init scripts). I haven't had time / bothered to debug this properly, but it should certainly be handled before stabilization (or at least properly tested to verify if it is specific to my setup).
Comment 3 Paolo Pedroni 2016-11-29 16:03:09 UTC
(In reply to Kristian Fiskerstrand from comment #2)
> (In reply to Paolo Pedroni from comment #1)
> > Fine for me. Only problem is that rb_libtorrent-1.0.10 is not stable. I'm
> 
> Is there a problem with making it stable as part of the process? 

rb_libtorrent mantainer (hwoarang) is quite slow to respond. There's a couple of security bug (#585278 and #593288) and a version bump (#580760) open for the package with no response from him yet.

Were it for me, I'd wait for rb_libtorrent-1.1.1 to show up and stabilize that in due course, or patch 1.0.10 for #593288.
Comment 4 Paolo Pedroni 2016-12-14 15:46:59 UTC
(In reply to Kristian Fiskerstrand from comment #2)
> (In reply to Paolo Pedroni from comment #1)
> > quite sure we can change back the dependency to
> > >=net-libs/rb_libtorrent-0.16.17 without any ill effects.
> 
> keep in mind that such a change will restart the count of package in ~arch
> for 30 days before stabilization so you might want to consider option #1
> above.

At this point, it's fine for me, and I'll fix bug #602424 at the same time.
Expect a patch in the next few days, work permitting.

> NB! I've run into certain issues with configuration getting lost on update
> and difficulties starting deluged (it is OK from the web interface, but not
> from init scripts). I haven't had time / bothered to debug this properly,
> but it should certainly be handled before stabilization (or at least
> properly tested to verify if it is specific to my setup).

Never happened to me, and no trace of currently open bugs regarding this at the time. If you can debug it more, please let me know.
Comment 5 Paolo Pedroni 2016-12-15 10:48:28 UTC
Created attachment 456290 [details, diff]
0002-net-p2p-deluge-Fix-dependency-on-net-libs-rb_libtorr.patch

This patch reverts the dependency on net-libs/rb_libtorrent to current stable and beyond and revbumps the package accordingly. In 30 days I'll send a patch to stabilize it if no bugs crop up.

I changed the dependency for all other unstable ebuilds too, for uniformity's sake.

Kristian, please review and apply.
Comment 6 Paolo Pedroni 2016-12-22 16:04:34 UTC
Sorry to bother you again, Kristian, but when you fixed bug #602424, you forgot to apply the patch in this bug to revert the dependency on rb_libtorrent to the older, stable version. Can you please do it?

Thanks in advance.
Comment 7 Agostino Sarubbo gentoo-dev 2016-12-28 09:03:17 UTC
Dear Maintainer (or who is mainly involved in this stable request),

This is an auto-generated message that will move the current component to the new component Stabilization.
To ensure that the stabilization will proceed correctly, please fill the fields "Atoms to stabilize" and "Runtime testing required" as described here:
https://archives.gentoo.org/gentoo-dev/message/4b2ef0e9aa7588224b8ae799c5fe31fa
Comment 8 Paolo Pedroni 2017-01-04 09:17:51 UTC
(In reply to Paolo Pedroni from comment #6)
> Sorry to bother you again, Kristian, but when you fixed bug #602424, you
> forgot to apply the patch in this bug to revert the dependency on
> rb_libtorrent to the older, stable version. Can you please do it?
> 
> Thanks in advance.

Please, Kristian, apply the attached patch which reverts the dependency on newer, unstable rb_libtorrent, so we can proceed with stabilization in due course.

Thanks.
Comment 9 Kristian Fiskerstrand (RETIRED) gentoo-dev 2017-01-05 19:12:19 UTC
(In reply to Paolo Pedroni from comment #8)
> (In reply to Paolo Pedroni from comment #6)
> > Sorry to bother you again, Kristian, but when you fixed bug #602424, you
> > forgot to apply the patch in this bug to revert the dependency on
> > rb_libtorrent to the older, stable version. Can you please do it?
> > 
> > Thanks in advance.
> 
> Please, Kristian, apply the attached patch which reverts the dependency on
> newer, unstable rb_libtorrent, so we can proceed with stabilization in due
> course.
> 
> Thanks.

The patch renames 1.3.13 to 1.3.13-r1, however this revision already exists, so I applied the fix manually for 1.3.13-r2. 1.3.12 should be removed once stabilization of this is done, so not needed to do anything about, the -9999 versions can't go stable so likely no reason to downgrade here.

commit 6e64dbcb7789e65ba12420a0369dc0de61640663
Author: Kristian Fiskerstrand <k_f@gentoo.org>
Date:   Thu Jan 5 20:11:07 2017 +0100

    net-p2p/deluge: Fix dependency on net-libs/rb_libtorrent.
    
    The newer version of the library is not strictly necessary and requires
    additional stabilization if to be used, so reducing the version requirement
    for 1.3.13 in order to stabilize the point version.
    
    Proxied-Maintainer: Paolo Pedroni
    Gentoo-Bug: 601048
    
    Package-Manager: Portage-2.3.3, Repoman-2.3.1
Comment 10 Pacho Ramos gentoo-dev 2017-02-03 11:38:53 UTC
All the packages need to go together in bug 530720

*** This bug has been marked as a duplicate of bug 530720 ***