Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 599492 - sys-apps/accountsservice: Add elogind support
Summary: sys-apps/accountsservice: Add elogind support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL: https://bugs.freedesktop.org/show_bug...
Whiteboard:
Keywords:
Depends on: 620976
Blocks: elogind-support
  Show dependency tree
 
Reported: 2016-11-11 15:54 UTC by Sven Eden
Modified: 2017-06-09 14:06 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
accountsservice-0.6.42-r4.ebuild (accountsservice-0.6.42-r4.ebuild,1.61 KB, text/plain)
2016-11-11 15:55 UTC, Sven Eden
Details
Patch to enable elogind support (accountsservice-enable-elogind.patch,2.76 KB, patch)
2016-11-11 15:57 UTC, Sven Eden
Details | Diff
accountsservice-0.6.43-r1.ebuild (accountsservice-0.6.43-r1.ebuild,1.61 KB, text/plain)
2016-12-06 08:29 UTC, Sven Eden
Details
Updated patch to enable elogind support (accountsservice-enable-elogind.patch,2.42 KB, patch)
2017-01-12 16:27 UTC, Sven Eden
Details | Diff
accountsservice-0.6.43.ebuild.diff (accountsservice-0.6.43.ebuild.diff,1.54 KB, patch)
2017-05-27 08:32 UTC, Andreas Sturmlechner
Details | Diff
Updated Patch to enable elogind support (accountsservice-enable-elogind.patch,2.70 KB, patch)
2017-06-01 11:44 UTC, Sven Eden
Details | Diff
Updated Patch to enable elogind support - configure.ac only (accountsservice-enable-elogind.patch,3.22 KB, patch)
2017-06-06 09:14 UTC, Sven Eden
Details | Diff
accountsservice-0.6.43.ebuild.diff (accountsservice-0.6.43.ebuild.diff,1.38 KB, patch)
2017-06-06 20:20 UTC, Andreas Sturmlechner
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sven Eden 2016-11-11 15:54:12 UTC
Add support for using elogind instead of systemd-logind for querying session and seat related user information.

This requires to patch in support, as accountsservice links against libsystemd-login.
Comment 1 Sven Eden 2016-11-11 15:55:27 UTC
Created attachment 453014 [details]
accountsservice-0.6.42-r4.ebuild

Updated ebuild that accepts sys-auth/elogind and adds a USE flag "elogind".

The support is patched in, the patch follows.
Comment 2 Sven Eden 2016-11-11 15:57:28 UTC
Created attachment 453016 [details, diff]
Patch to enable elogind support

This patch changes the following:

a) Add "--enable-elogind" to configure.ac
b) Make src/libaccountsservice/act-user-manager.c include <elogind/sd-login.h> if --enable-elogind was set.
Comment 3 Sven Eden 2016-12-06 08:29:30 UTC
Created attachment 455244 [details]
accountsservice-0.6.43-r1.ebuild

Version bump with elogind support.

As the previous version is based on the stable 0.6.42 version, I'll keep it in my overlay.
Comment 4 Sven Eden 2017-01-12 16:27:13 UTC
Created attachment 459788 [details, diff]
Updated patch to enable elogind support

This patch does enable elogind in a bit cleaner way.
Comment 5 Andreas Sturmlechner gentoo-dev 2017-01-13 22:59:37 UTC
It is a bit unfortunate but I guess it won't do without patching. I've used a symlink to /usr/include/systemd in my local overlay elogind copy to avoid touching code, but that does not avoid the buildsystem part. Have you already tried to submit it upstream?
Comment 6 Andreas Sturmlechner gentoo-dev 2017-05-27 08:32:53 UTC
Created attachment 474504 [details, diff]
accountsservice-0.6.43.ebuild.diff

unconditionally patch elogind support
Comment 7 Mart Raudsepp gentoo-dev 2017-05-27 19:20:33 UTC
(In reply to Andreas Sturmlechner from comment #5)
> Have you already tried to submit it upstream?

Any updates on this?

Instead of adding src_prepare, set GNOME2_EAUTORECONF="yes" after EAPI, before inherit.

Reluctant to ACK it without upstream See Also bug at the very least.
Comment 8 Sven Eden 2017-05-31 12:32:43 UTC
I just realized that I forgot to post my patch upstream. How embarrassing!

Well, here it is:

https://bugs.freedesktop.org/show_bug.cgi?id=101251
Comment 9 Sven Eden 2017-06-01 11:44:11 UTC
Created attachment 474904 [details, diff]
Updated Patch to enable elogind support

I have made the configure.ac part a bit clearer, and the source part a bit cleaner. Applies nicely, so far.
Comment 10 Sven Eden 2017-06-06 09:14:33 UTC
Created attachment 475330 [details, diff]
Updated Patch to enable elogind support - configure.ac only

This is an updated patch, that no longer needs to change any source files, like requested by upstream.

For this patch to be useful, elogind-229.4 must be used as the minimal version.
So the line
  elogind? ( sys-auth/elogind )
must be changed into
  elogind? ( >=sys-auth/elogind-229.4 )
in the ebuild.
Comment 11 Sven Eden 2017-06-06 16:10:26 UTC
Patch accepted by upstream with minor changes:

https://cgit.freedesktop.org/accountsservice/commit/?id=9fdd1d95ec094a0df6d8d3dd9c8f04fa8499b845

So until the new version gets released, we can do with patching against >=sys-auth/elogind-229.4 it seems.
Comment 12 Andreas Sturmlechner gentoo-dev 2017-06-06 19:21:23 UTC
Very nicely done - thanks!
Comment 13 Andreas Sturmlechner gentoo-dev 2017-06-06 20:20:58 UTC
Created attachment 475420 [details, diff]
accountsservice-0.6.43.ebuild.diff
Comment 14 Michael Palimaka (kensington) gentoo-dev 2017-06-09 14:06:01 UTC
Thanks, fixed in git.

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bd4281d8c205c8c426fd85433717397c4a561793