gvfs uses some features from systemd-logind that can be provided by sys-auth/elogind, too. Namely this is gvfs-udisks2-volume-monitor, and possibly other parts utilizing gvfsudisks2utils.c. An update is looks simple: Patch in elogind support into configure.ac, and have gvfsudisks2utils.c include <elogind/sd-login.h> instead of the systemd variant.
Created attachment 452998 [details] gvfs-1.28.3-r2.ebuild Ebuild enabling elogind USE flag and patching of the sources. Patch will follow.
Created attachment 453002 [details, diff] Enable elogind support This patch adds: 1) --enable-libelogind in configure.ac 2) LIBELOGIND_CFLAGS and _LIBS in monitor/udisks2/Makefile.am 3) #include <elogind/sd-login.h> in monitor/udisks2/gvfsudisks2utils.c
Created attachment 453270 [details] gvfs-1.30.2-r1.ebuild Most recent version with patched in elogind support
@kensington @leio : I haven't found any issues with the patched ebuild on my system. *but* : On my system only x11-libs/libfm depends on gvfs, and that is used by lxqt. I am not using lxqt very often, so some more testing would be useful. However, the changes are rather subtle so it might be helpful to bring the updated ebuild and its patch into the kde overlay for wider testing.
Any chan
(In reply to Joakim Tjernlund from comment #5) > Any chan Arg, hit save by mistake. Ment to say: Any chanse
(In reply to Joakim Tjernlund from comment #6) > (In reply to Joakim Tjernlund from comment #5) > > Any chan > > Arg, hit save by mistake. > Ment to say: > Any chanse hmm, some thing is odd here in my browser so I better be careful hitting the keyboard ... Any chance this change will move into the Gentoo tree soon?
(In reply to Joakim Tjernlund from comment #7) > Any chance this change will move into the Gentoo tree soon? I have no idea, but at least the bug mail remindet me, that there are still some packages in my overlay with elogind support that did not make it into the tree, yet. And gvfs isn't bumped there, yet. Currently I have little time, until the end of next week at least. But I will bump gvfs in my overlay, see what patching still must be done, and if so, propose those patches upstream.
I spoke to GNOME team about this a while back, and if I recall correctly unfortunately they weren't interested in patching this (or any other package they maintain) unless it landed upstream.
(In reply to Michael Palimaka (kensington) from comment #9) > I spoke to GNOME team about this a while back, and if I recall correctly > unfortunately they weren't interested in patching this (or any other package > they maintain) unless it landed upstream. I have pushed an updated version of the patch for the new gnome-base/gvfs-1.32.1-r1 ebuild, and will see to it that it is proposed upstream.
Created attachment 498164 [details] gnome-base/gvfx-1.32.1-r1.ebuild Updated ebuild for the current version of gvfs-1.32.1 adding elogind support
Created attachment 498166 [details, diff] New patch to enable elogind support for gvfs-1.32.1 Patch for the new gvfs version. Fortunately the patch got a lot simpler, so I hope it will be accepted by upstream soon.
I have filed https://bugzilla.gnome.org/show_bug.cgi?id=788707
(In reply to Sven Eden from comment #13) > I have filed > > https://bugzilla.gnome.org/show_bug.cgi?id=788707 Looks like this is commited upstream now, only for meson builds though.
(In reply to Joakim Tjernlund from comment #14) > (In reply to Sven Eden from comment #13) > > I have filed > > > > https://bugzilla.gnome.org/show_bug.cgi?id=788707 > > Looks like this is commited upstream now, only for meson builds though. Yes, they are going the systemd way and substitute the autotools with meson. I can understand that, meson+ninja is pretty cool and much easier to learn and maintain as the autotools. However, elogind is accepted upstream, and that was the goal anyway.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a25e1a715f98f9b96070a22b75509e92ced16961 commit a25e1a715f98f9b96070a22b75509e92ced16961 Author: Mart Raudsepp <leio@gentoo.org> AuthorDate: 2018-01-08 16:14:32 +0000 Commit: Mart Raudsepp <leio@gentoo.org> CommitDate: 2018-01-08 16:32:34 +0000 gnome-base/gvfs: elogind support, mtp unmount fix, other upstream patches Grab all commits (except version bump to 1.32.2) from upstream gnome-3-24 branch and mtp unmount fix from gnome-3-26 branch. Include patch for elogind support and integrate it in the ebuild. Closes: https://bugs.gentoo.org/599482 Closes: https://bugs.gentoo.org/641522 Package-Manager: Portage-2.3.19, Repoman-2.3.6 gnome-base/gvfs/Manifest | 1 + gnome-base/gvfs/gvfs-1.32.1-r1.ebuild | 134 ++++++++++++++++++++++++++++++++++ gnome-base/gvfs/metadata.xml | 1 + 3 files changed, 136 insertions(+)
I had to grab the patch and do the ebuild changes myself, as upstream attachment was different than what is attached here (git format-patch with more information, a bit different configure constructs), and the ebuild had unacceptable conditional patching and eautoreconf'ing (would end up with unknown configure flag QA warnings from the use_enable use too), plus coming from patchset instead of $FILESDIR. Please test I didn't fail somewhere and that it still works with USE=elogind as needed. Obviously I couldn't do that myself.
(In reply to Mart Raudsepp from comment #17) > I had to grab the patch and do the ebuild changes myself, as upstream > attachment was different than what is attached here (git format-patch with > more information, a bit different configure constructs), and the ebuild had > unacceptable conditional patching and eautoreconf'ing (would end up with > unknown configure flag QA warnings from the use_enable use too), plus coming > from patchset instead of $FILESDIR. > > Please test I didn't fail somewhere and that it still works with USE=elogind > as needed. Obviously I couldn't do that myself. Thank you very much, I'll test this in the next few days.
