Created attachment 452904 [details, diff] Replace which with command-v On some systems /usr/bin/which might not be available, it's safer to use "command -v". Patch attached.
(In reply to Manuel Rüger from comment #0) > Created attachment 452904 [details, diff] [details, diff] > Replace which with command-v > > On some systems /usr/bin/which might not be available, it's safer to use > "command -v". > > Patch attached. command -v doesn't require an external binary, but it's not POSIX either. bash/dash/zsh/csh/FreeBSD sh all support it, though busybox doesn't. I suspect plenty else wouldn't work under busybox though ;). Why the quoting, though?
Yeah the quoting is not necessary. I check busybox: mrueg@euler ~ % bb ~ $ command -v eselect /usr/bin/eselect Seems to be supported there as well.
(In reply to Manuel Rüger from comment #2) > Yeah the quoting is not necessary. > > I check busybox: > > mrueg@euler ~ % bb > ~ $ command -v eselect > /usr/bin/eselect > > > Seems to be supported there as well. Cool. I committed the modified patch here: https://gitweb.gentoo.org/proj/eselect-java.git/commit/?id=4d7da7ac603f610fef687ea95357e7b727b19d03 and pushed a 0.3.0 ebuild here: https://github.com/gentoo/gentoo/commit/588325937049c7ca75da537f615c961c64b7e2a4
