Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 599346 - dev-util/electron-0.37.8 fails to build against >=dev-libs/icu-58.1
Summary: dev-util/electron-0.37.8 fails to build against >=dev-libs/icu-58.1
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Elvis Pranskevichus
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: CVE-2016-7415
  Show dependency tree
 
Reported: 2016-11-09 21:57 UTC by Michael Reithinger
Modified: 2016-11-18 23:58 UTC (History)
7 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
emerge --info '=dev-util/electron-0.37.8::gentoo' (emerge-info.txt,6.13 KB, text/plain)
2016-11-09 21:57 UTC, Michael Reithinger 		Details
emerge -pqv '=dev-util/electron-0.37.8::gentoo' (emerge-pqv.txt,437 bytes, text/plain)
2016-11-09 21:58 UTC, Michael Reithinger 		Details
build log (build.log.bz2,281.71 KB, application/x-bzip)
2016-11-09 22:02 UTC, Michael Reithinger 		Details
Patch adapted from chromium (icu-58.patch,2.71 KB, patch)
2016-11-11 23:52 UTC, Brad Laue 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Reithinger 2016-11-09 21:57:17 UTC 
Created attachment 452838 [details]
emerge --info '=dev-util/electron-0.37.8::gentoo'

The same patch as in https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c72212dd should do it.
Comment 1 Michael Reithinger 2016-11-09 21:58:20 UTC 
Created attachment 452840 [details]
emerge -pqv '=dev-util/electron-0.37.8::gentoo'
Comment 2 Michael Reithinger 2016-11-09 22:02:05 UTC 
Created attachment 452842 [details]
build log
Comment 3 Brad Laue 2016-11-11 23:52:14 UTC 
Created attachment 453074 [details, diff]
Patch adapted from chromium

The patch for chromium fails to directly apply, probably version differences. I trimmed it to the following, which allows electron to build successfully.
Comment 4 Elvis Pranskevichus 2016-11-18 23:58:06 UTC 
Fixed in https://github.com/gentoo/gentoo/pull/2835