Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 598244 - =app-emulation/wine-1.9.20 fail2 to build with sys-devel/flex-2.6.2
Summary: =app-emulation/wine-1.9.20 fail2 to build with sys-devel/flex-2.6.2
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: flex-2.6.2
  Show dependency tree
 
Reported: 2016-10-27 13:12 UTC by slvrn
Modified: 2017-04-25 08:04 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge -pqv wine (emerge-pqv-wine.txt,688 bytes, text/plain)
2016-10-27 13:12 UTC, slvrn
Details
build.log (wine-build.log,306.33 KB, text/plain)
2016-10-27 13:13 UTC, slvrn
Details
emerge --info (emerge-info.txt,5.68 KB, text/plain)
2016-10-27 13:13 UTC, slvrn
Details

Note You need to log in before you can comment on or make changes to this bug.
Description slvrn 2016-10-27 13:12:04 UTC
Created attachment 451586 [details]
emerge -pqv wine

The output of 'emerge --info', 'emerge -pqv wine ' and build.log is attached
Comment 1 slvrn 2016-10-27 13:13:01 UTC
Created attachment 451588 [details]
build.log
Comment 2 slvrn 2016-10-27 13:13:39 UTC
Created attachment 451590 [details]
emerge --info
Comment 3 slvrn 2016-10-27 13:16:00 UTC
With sys-devel/flex-2.6.1 it builds succesfully
Comment 4 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2017-01-02 12:18:56 UTC
commit 2601a5c0e5304ddb0b9b1d608b5b12ce04dc3a90
Author: Lars Wendler <polynomial-c@gentoo.org>
Date:   Fri Dec 30 22:18:40 2016

    sys-devel/flex: Bump to version 2.6.3

    Removed completely broken 2.6.2 version.

    Package-Manager: Portage-2.3.3, Repoman-2.3.1


commit cc9f166fe9cd2176ad5bbd41300390e5d8f8a575
Author: Lars Wendler <polynomial-c@gentoo.org>
Date:   Mon Jan 2 12:36:22 2017

    app-emulation/wine: Fixed compilation with =sys-devel/flex-2.6.3

    Package-Manager: Portage-2.3.3, Repoman-2.3.1
Comment 5 Adam Feldman gentoo-dev 2017-01-02 16:38:51 UTC
> 
> commit cc9f166fe9cd2176ad5bbd41300390e5d8f8a575
> Author: Lars Wendler <polynomial-c@gentoo.org>
> Date:   Mon Jan 2 12:36:22 2017
> 
>     app-emulation/wine: Fixed compilation with =sys-devel/flex-2.6.3
> 
>     Package-Manager: Portage-2.3.3, Repoman-2.3.1

Was this patch submitted upstream?  I prefer not to add patches downstream without inquiring about getting them upstream first.  Particularly since I've told this to the patch author several times before.  I'd rather avoid just reverting your fix, so please do the due diligence and submit the patch upstream.

Our policy is to support all ebuilds from the current branches devel and stable (which would have been known if you asked me about it when we spoke the other day), so please patch all of the remaining ebuilds
Comment 6 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2017-01-02 17:03:42 UTC
(In reply to NP-Hardass from comment #5)
> > 
> > commit cc9f166fe9cd2176ad5bbd41300390e5d8f8a575
> > Author: Lars Wendler <polynomial-c@gentoo.org>
> > Date:   Mon Jan 2 12:36:22 2017
> > 
> >     app-emulation/wine: Fixed compilation with =sys-devel/flex-2.6.3
> > 
> >     Package-Manager: Portage-2.3.3, Repoman-2.3.1
> 
> Was this patch submitted upstream?  I prefer not to add patches downstream
> without inquiring about getting them upstream first.  Particularly since
> I've told this to the patch author several times before.  I'd rather avoid
> just reverting your fix, so please do the due diligence and submit the patch
> upstream.
> 
> Our policy is to support all ebuilds from the current branches devel and
> stable (which would have been known if you asked me about it when we spoke
> the other day), so please patch all of the remaining ebuilds

If you'd have looked into my commit you'd have seen this comment in the ebuild:

https://bugs.winehq.org/show_bug.cgi?id=42132
Comment 7 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2017-01-02 17:38:49 UTC
commit 6f6d1f04bc2704a55adfdc3a73c525eaa3325366
Author: Lars Wendler <polynomial-c@gentoo.org>
Date:   Mon Jan 2 18:36:31 2017

    app-emulation/wine: Apply flex263 patch to all available ebuilds

    as requested by wine maintainer.

    Package-Manager: Portage-2.3.3, Repoman-2.3.1
Comment 8 Adam Feldman gentoo-dev 2017-01-25 00:28:20 UTC
Upstream Flex fixed this issue [1][2][3].  Please backport this so I can remove this patch from Wine.


[1]https://github.com/westes/flex/issues/155
[2]https://github.com/westes/flex/issues/162
[3]https://github.com/westes/flex/commit/078b46c69d063aef1715b11348a2871d6036f253
Comment 9 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2017-04-25 08:04:15 UTC
commit b4f455b89cd6fd4b72ee4ec1626ed7a20bd5f28a
Author: Lars Wendler <polynomial-c@gentoo.org>
Date:   Thu Mar 23 13:19:46 2017

    sys-devel/flex: Added upstream reentrant patch to fix wine breakage.

    See https://bugs.winehq.org/show_bug.cgi?id=42132

    Package-Manager: Portage-2.3.5, Repoman-2.3.2