Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 597132 - app-portage/gentoolkit-0.3.2-r1: eread: line 64: break: only meaningful in a `for', `while', or `until' loop
Summary: app-portage/gentoolkit-0.3.2-r1: eread: line 64: break: only meaningful in a ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Portage Tools Team
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks:
 
Reported: 2016-10-14 20:04 UTC by Amadeusz Żołnowski (RETIRED)
Modified: 2022-07-10 23:08 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Amadeusz Żołnowski (RETIRED) gentoo-dev 2016-10-14 20:04:39 UTC 
When running eread for empty elog dir, it loops forever:

This is a list of portage log items. Choose a number to view that file or type q to quit.

No log items to read
/usr/bin/eread: line 64: break: only meaningful in a `for', `while', or `until' loop
Comment 1 Paul Varner (RETIRED) gentoo-dev 2016-10-17 16:44:57 UTC 
The code in question is inside a function inside an until loop and this used to work fine. However, I will refactor the code to put the until loop in the function and fix the issue.
Comment 2 Paul Varner (RETIRED) gentoo-dev 2016-10-17 17:41:40 UTC 
Fix pushed to the gentoolkit repository.
https://gitweb.gentoo.org/proj/gentoolkit.git/commit/?id=b5e71f6f2ed3483422df611fc2450081c72332ac

This can be tested with gentoolkit-9999