Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 592912 - sys-apps/ifplugd-0.28-r9 fails to compile in hardened/linux/musl/amd64 profile.
Summary: sys-apps/ifplugd-0.28-r9 fails to compile in hardened/linux/musl/amd64 profile.
Status: UNCONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Hardened (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo musl team
URL:
Whiteboard:
Keywords:
Depends on: 604222
Blocks:
  Show dependency tree
 
Reported: 2016-09-05 09:59 UTC by Chad Joan
Modified: 2016-12-31 16:18 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Full build log. (sys-apps_ifplugd-0.28-r9_build.log,9.86 KB, text/x-log)
2016-09-05 09:59 UTC, Chad Joan
Details
Patch. (ifplugd-0.28-ethtool-local-bug592912.patch,490 bytes, patch)
2016-09-05 10:34 UTC, Chad Joan
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chad Joan 2016-09-05 09:59:45 UTC
Created attachment 445000 [details]
Full build log.

When compiling halts, it looks like this:

In file included from interface.c:40:0:
ethtool-local.h:25:9: error: unknown type name '__uint32_t'
 typedef __uint32_t u32;        
         ^
ethtool-local.h:26:9: error: unknown type name '__uint16_t'
 typedef __uint16_t u16;        
         ^
ethtool-local.h:27:9: error: unknown type name '__uint8_t'
 typedef __uint8_t u8;

... and so on...

I believe this is musl-related because the __uintNN_t usage looks not-totally-portable and ifplugd has always compiled fine for me on non-musl profiles.

It probably just needs some #include <stdint.h>
Comment 1 Chad Joan 2016-09-05 10:34:25 UTC
Created attachment 445002 [details, diff]
Patch.

This patch allows it to compile successfully on my system.
Comment 2 Felix Janda 2016-09-05 12:01:36 UTC
Patch looks good. Thanks!

This bug should block bug 430702 and be reassigned to base-system.
Comment 3 Chad Joan 2016-09-05 13:59:43 UTC
Thank you for working on the musl port :)

I did not know about bug 430702.  I suppose if I run into other notable broken builds then I will make those block it too (while checking for dups, of course).
Comment 4 Felix Janda 2016-09-05 16:19:31 UTC
Yes, all build failures related to musl should block that bug.
Comment 5 Felix Janda 2016-10-31 09:50:51 UTC
sys-apps/ifplugd-0.28-r10 now has your patch, and should build without
problems.
Comment 6 Chad Joan 2016-12-31 05:43:56 UTC
sys-apps/ifplugd-0.28-r10 compiles fine on my system.  :)

Please mask sys-apps/ifplugd-0.28-r9 in the hardened-musl profile if you're not going to patch it too.  People like me who tend to merge stable packages by default would get the unpatched r9 currently in the tree and it would break their build.
Comment 7 Chad Joan 2016-12-31 16:18:17 UTC
Cool thanks, I think that is also a good idea :)

Hope it works.