Created attachment 444534 [details] build.log x86_64-pc-linux-gnu-gcc -c -fwrapv -fno-strict-aliasing -pipe -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -march=native -mtune=native -O2 -pipe -DVERSION=\"0.06\" -DXS_VERSION=\"0.06\" -fPIC "-I/usr/lib64/perl5/5.24.0/x86_64-linux/CORE" -DPERL5 -DOPENSSL_NO_KRB5 Bignum.c Bignum.xs: In function ‘XS_Crypt__OpenSSL__Bignum_new’: Bignum.xs:95:5: error: invalid use of void expression checkOpenSslCall( BN_zero( bn ) ); ^ Bignum.xs: In function ‘XS_Crypt__OpenSSL__Bignum_zero’: Bignum.xs:106:5: error: invalid use of void expression checkOpenSslCall( BN_zero( bn ) ); ^ Bignum.xs: In function ‘boot_Crypt__OpenSSL__Bignum’: Bignum.xs:32:5: warning: implicit declaration of function ‘ERR_load_crypto_strings’ [-Wimplicit-function-declaration] ERR_load_crypto_strings(); ^ make: *** [Makefile:348: Bignum.o] Error 1
* I've added 0.70.0, but I dont see anything related in the changelog, so this likely still is an issue. * Strangely Debian doesnt patch the package. ???
RH doesnt patch the package either ("Rebuild against 1.1"), so something is odd here.
They don't patch the package because they still ship deprecated features in their openssl-1.1 packages. Our openssl-1.1 packages currently don't provide deprecated features.
Created attachment 498938 [details, diff] Crypt-OpenSSL-Bignum-0.80.0-openssl-1.1.patch Patch by me, I can try to upstream it if you like, thanks.
(In reply to Mark Wright from comment #4) > Created attachment 498938 [details, diff] [details, diff] > Crypt-OpenSSL-Bignum-0.80.0-openssl-1.1.patch > > Patch by me, I can try to upstream it if you like, thanks. Patch should be applied upstream eventually anyway, so go ahead and submit it there if you want. But I'll mainline it in gentoo in an -r1 when I get time.
Patch submitted upstream, going to land in gentoo ASAP. https://github.com/kmx/perl-Crypt-OpenSSL-Bignum/pull/7
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=de872dbfadcb881f6dc7dd0b79760b5e11628fcd commit de872dbfadcb881f6dc7dd0b79760b5e11628fcd Author: Kent Fredric <kentnl@gentoo.org> AuthorDate: 2017-10-19 01:44:28 +0000 Commit: Kent Fredric <kentnl@gentoo.org> CommitDate: 2017-10-19 01:45:23 +0000 dev-perl/Crypt-OpenSSL-Bignum: Fix for OpenSSL 1.1.0f Bug: https://bugs.gentoo.org/592532 Package-Manager: Portage-2.3.8, Repoman-2.3.3 .../Crypt-OpenSSL-Bignum-0.80.0-r1.ebuild | 24 +++++++++++ .../Crypt-OpenSSL-Bignum-0.80.0-openssl1.1.patch | 49 ++++++++++++++++++++++ 2 files changed, 73 insertions(+)}
Upstream 0.09 (which would probably be 0.90.0 in gentoo) contains the patch: http://cpansearch.perl.org/src/KMX/Crypt-OpenSSL-Bignum-0.09/Changes
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=635d56fb9faa93e7d10edabbee1aa642270fb967 commit 635d56fb9faa93e7d10edabbee1aa642270fb967 Author: Craig Andrews <candrews@gentoo.org> AuthorDate: 2018-04-13 19:36:44 +0000 Commit: Aaron Bauman <bman@gentoo.org> CommitDate: 2018-04-23 15:12:37 +0000 dev-perl/Crypt-OpenSSL-Bignum: 0.90.0 version bump Closes: https://bugs.gentoo.org/647532 Bug: https://bugs.gentoo.org/592532 Package-Manager: Portage-2.3.28, Repoman-2.3.9 Closes: https://github.com/gentoo/gentoo/pull/7974 .../Crypt-OpenSSL-Bignum-0.90.0.ebuild | 23 ++++++++++++++++++++++ dev-perl/Crypt-OpenSSL-Bignum/Manifest | 1 + 2 files changed, 24 insertions(+)}
As this is fixed with 0.90.0, which is already stabilized, we can close, right?
Issue was kept open until affected versions are purged from tree. Looking into cleaning up old versions atm.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=467e51993c34f0d1794baea5ecca4a298db3439d commit 467e51993c34f0d1794baea5ecca4a298db3439d Author: Kent Fredric <kentnl@gentoo.org> AuthorDate: 2018-09-23 06:03:06 +0000 Commit: Kent Fredric <kentnl@gentoo.org> CommitDate: 2018-09-23 06:04:08 +0000 dev-perl/Crypt-OpenSSL-Bignum: Cleanup old versions 0.{4,7,8}0* re bug #592532 Removing old versions broken with openssl1.1 installed. Closes: https://bugs.gentoo.org/592532 Package-Manager: Portage-2.3.49, Repoman-2.3.10 .../Crypt-OpenSSL-Bignum-0.40.0-r2.ebuild | 22 ---------- .../Crypt-OpenSSL-Bignum-0.70.0.ebuild | 23 ---------- .../Crypt-OpenSSL-Bignum-0.80.0-r1.ebuild | 24 ----------- .../Crypt-OpenSSL-Bignum-0.80.0.ebuild | 23 ---------- dev-perl/Crypt-OpenSSL-Bignum/Manifest | 3 -- .../Crypt-OpenSSL-Bignum-0.80.0-openssl1.1.patch | 49 ---------------------- 6 files changed, 144 deletions(-)
