Bug 591784 – sys-cluster/nova: try to avoid cdrkit requirement

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Pacho Ramos 2016-08-21 09:20:40 UTC]

cdrkit is dead for ages and with lots of known bugs, but this looks to hard require cdrkit, then this should be either fixed to allow cdrtools or other backends or probably be treecleaned

[Comment 1 Matthew Thode ( prometheanfire ) 2016-08-22 00:25:09 UTC]

Nova makes use of `genisoimage` (in `nova/conf/configdrive.py`).  So at the moment it's not changable, I'm not sure it's tracked upstream either.

[Comment 2 Pacho Ramos 2016-08-22 09:23:04 UTC]

Does it work when sedding it to use mkisofs? It should, but maybe upstream is forcing it for the licensing issue :/

[Comment 3 Matthew Thode ( prometheanfire ) 2016-08-22 11:50:09 UTC]

license issue?  I'd suggest making a bug against nova to get some real answers.

[Comment 4 Pacho Ramos 2016-08-22 15:28:03 UTC]

Reading nova/conf/configdrive.py, wouldn't it be a matter of setting mkisofs_cmd to /usr/bin/mkisofs ?

[Comment 5 Pacho Ramos 2016-10-08 06:54:37 UTC]

As explained by upstream, we should edit the config file to point to mkisofs:
https://bugs.launchpad.net/nova/+bug/1629555/comments/5

[Comment 6 Pacho Ramos 2016-10-15 10:14:00 UTC]

And other option would be to use sed to change:
nova/conf/configdrive.py
mkisofs_cmd_opt = cfg.StrOpt('mkisofs_cmd',
        default='genisoimage',
        help="""

Changing default from genisoimage to mkisofs

[Comment 7 Pacho Ramos 2016-11-10 12:42:35 UTC]

Can this be reviewed? This is the last cdrkit consumer in the tree

Thanks

[Comment 8 Pacho Ramos 2016-11-27 18:41:32 UTC]

I would opt for the sed against nova/conf/configdrive.py :/

[Comment 9 Matthew Thode ( prometheanfire ) 2016-11-27 19:56:04 UTC]

I simply don't feel comfortable supporting the modification of code in this way.  The correct fix as per upstream is to set it via the config file.

[Comment 10 Pacho Ramos 2016-11-28 16:13:37 UTC]

Then... if you could finally provide that config file, I guess it would be needed for 14.0.2 and the *9999 versions as older ebuilds could be removed in the future, right? :/

[Comment 11 Matthew Thode ( prometheanfire ) 2016-11-28 16:22:02 UTC]

I could add it to the sample (probably via sed there), but that's just the sample.

[Comment 12 Matthew Thode ( prometheanfire ) 2016-11-28 16:28:29 UTC]

we could have a second config file (/etc/conf.d/nova-compute.conf or something) and change init for that to specify that along with the default location.

[Comment 13 Pacho Ramos 2016-11-28 21:07:03 UTC]

Well... you are the guy with the most knowledge about nova here (I only care because of the cdrkit dep), hence, as soon as mkisofs from cdrtools is finally used, feel free to choose the option that fits better for you and the users of this package :)

[Comment 14 Matthew Thode ( prometheanfire ) 2016-11-29 00:49:29 UTC]

Fixed the live versions of both mitaka and newton, the next bump will have it.