591518 – net-misc/remmina-1.2.0_rc14-r1 - add spice to IUSE, fix automagic dep behavior

Bug 591518 - net-misc/remmina-1.2.0_rc14-r1 - add spice to IUSE, fix automagic dep behavior

Summary: net-misc/remmina-1.2.0_rc14-r1 - add spice to IUSE, fix automagic dep behavior

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Diogo Pereira

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2016-08-17 14:47 UTC by Ben Kohler
Modified:	2016-08-18 06:46 UTC (History)
CC List:	1 user (show)

See Also:	https://github.com/gentoo/gentoo/pull/2096
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Ben Kohler gentoo-dev

2016-08-17 14:47:36 UTC

Remmina has support for the SPICE protocol but currently it's enabled/disabled automagically depending on whether spice-gtk is installed or not.  I've been maintaining remmina in an overlay for some time and this is one of the changes I noticed your new ebuild needs, I may have a few more later.

I believe we need to:

1. add spice to IUSE
2. add "spice? ( >=net-misc/spice-gtk-0.31[gtk3] )" to RDEPEND
3. add "-DWITH_SPICE=$(usex spice)" to mycmakeargs

Thanks!

Comment 1 Yixun Lan archtester

2016-08-18 06:46:49 UTC

pushed, but I have comments about removing the old ebuilds, 

1) request new stable version before remove old stable ones
2) any reason why remove the live ebuild (-9999), not update it?
(please open a new bug/PR for removing the old if you still want to..)

thanks for your contribution!

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=081a6b99489c18cbb1f0b3097750c2450853b99e