Bug 589796 – sys-fs/eudev: Prefix support

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Benda Xu 2016-07-27 03:09:09 UTC]

Created attachment 441670 [details, diff]
eudev-prefix.patch

Hi, this patch make eudev to be configured with correct Prefix directories.  Please have a look.  Thanks!


--exec-prefix is by default set to --prefix in configure, which in turn is by default set by econf.  Therefore it is not needed.

[Comment 1 Benda Xu 2016-08-01 01:49:26 UTC]

Hi, I am going to land the patch in tree in a week if there is no objections.

[Comment 2 Ian Stakenvicius (RETIRED) 2016-08-01 01:52:27 UTC]

Go for it.  I don't have commit access for another couple of days otherwise I would do it.

Blueness, any objections?

[Comment 3 Benda Xu 2016-08-01 04:32:20 UTC]

(In reply to Benda Xu from comment #0)
> Created attachment 441670 [details, diff] [details, diff]
> eudev-prefix.patch
> 
> Hi, this patch make eudev to be configured with correct Prefix directories. 
> Please have a look.  Thanks!
> 
> --exec-prefix is by default set to --prefix in configure, which in turn is
> by default set by econf.  Therefore it is not needed.

Sorry, at a second thought --exec-prefix=${EPREFIX} is needed here. Because --prefix defaults to ${EPREFIX}/usr, not as intended here.

(In reply to Ian Stakenvicius from comment #2)
> Go for it.  I don't have commit access for another couple of days otherwise
> I would do it.

Thanks again Ian.

> Blueness, any objections?

Cool, I will act after having blueness' ack.

[Comment 4 Anthony Basile 2016-08-01 04:50:26 UTC]

(In reply to Benda Xu from comment #3)
> (In reply to Benda Xu from comment #0)
> > Created attachment 441670 [details, diff] [details, diff] [details, diff]
> > eudev-prefix.patch
> > 
> > Hi, this patch make eudev to be configured with correct Prefix directories. 
> > Please have a look.  Thanks!
> > 
> > --exec-prefix is by default set to --prefix in configure, which in turn is
> > by default set by econf.  Therefore it is not needed.
> 
> Sorry, at a second thought --exec-prefix=${EPREFIX} is needed here. Because
> --prefix defaults to ${EPREFIX}/usr, not as intended here.
> 
> (In reply to Ian Stakenvicius from comment #2)
> > Go for it.  I don't have commit access for another couple of days otherwise
> > I would do it.
> 
> Thanks again Ian.
> 
> > Blueness, any objections?
> 
> Cool, I will act after having blueness' ack.

go for it.

[Comment 5 Benda Xu 2016-08-01 05:51:35 UTC]

Landed.  Thanks!

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c42c9b0ad61f53caa4f13789fde90f3b7ee2bef2