Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 589530 - sys-fs/eudev: use of REPLACING_VERSIONS does not account for multiple values
Summary: sys-fs/eudev: use of REPLACING_VERSIONS does not account for multiple values
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal QA (vote)
Assignee: eudev team
URL:
Whiteboard:
Keywords: QAcanfix
Depends on:
Blocks: 589444
  Show dependency tree
 
Reported: 2016-07-23 13:06 UTC by Michał Górny
Modified: 2016-07-25 16:21 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2016-07-23 13:06:10 UTC
See the tracker bug.

  if [[ ${REPLACING_VERSIONS%-r*} == ${PV} || -z ${REPLACING_VERSIONS} ]] && ...

Doesn't account for >1 value in RV.
Comment 1 Ian Stakenvicius (RETIRED) gentoo-dev 2016-07-25 16:21:30 UTC
commit fe65dbd02d9a1131340e7c5aff86b3f53030d0d4
Author: Ian Stakenvicius <axs@gentoo.org>
Date:   Mon Jul 25 12:15:27 2016 -0400

sys-fs/eudev: ensure REPLACING_VERSIONS is processed as a list
    
REPLACING_VERSIONS is used in eudev ebuilds during pkg_postinst to determine
when udevadm control --reload should be called:
- when it is a new installation of udev
- when it is a re-emerge of the same version (or a revision-only upgrade)
    
REPLACING_VERSIONS *should* only ever have zero or one values, but it is
theoretically possible for it to have more than that if, for instance, a previous
upgrade failed to complete during qmerge.  If this is the case, and only one of
the multiple versions match the version of the ebuild, then we also abort as we
don't know which one is the "good" one.
    
Also removed duplicate code that reloads the hwdb (looks like it was a copy-paste
from sys-fs/udev)
    
Bug: http://bugs.gentoo.org/589530