589486 – net-fs/netatalk: use of REPLACING_VERSIONS does not account for multiple values

Bug 589486 - net-fs/netatalk: use of REPLACING_VERSIONS does not account for multiple values

Summary: net-fs/netatalk: use of REPLACING_VERSIONS does not account for multiple values

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal QA (vote)
Assignee:	Justin Lecher (RETIRED)

URL:
Whiteboard:
Keywords:	QAcanfix

Depends on:
Blocks:	589444
	Show dependency tree

Reported:	2016-07-23 12:47 UTC by Michał Górny
Modified:	2016-10-23 20:53 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michał Górny archtester

2016-07-23 12:47:47 UTC

See the tracker bug.

  if [[ ${REPLACING_VERSIONS} < 3 ]]; then

This doesn't account for RV being empty or having >1 value. Furthermore, < is lexicographical string comparison, so 10 < 3.

Comment 1 Justin Lecher (RETIRED) gentoo-dev

2016-10-23 20:53:21 UTC

commit 67c8fba9a98da19f01e21f6c322d95097bd5aeb7
Author: Justin Lecher <jlec@gentoo.org>
Date:   Sun Oct 23 22:52:49 2016 +0200

    net-fs/netatalk: Properly use REPLACING_VERSIONS

    Drop old

    Gentoo-Bug: https://bugs.gentoo.org/show_bug.cgi?id=589486

    Package-Manager: portage-2.3.2
    Signed-off-by: Justin Lecher <jlec@gentoo.org>

    https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=67c8fba9a98da19f01e21f6c322d95097bd5aeb7