Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 588764 - x11-misc/lightdm-gtk-greeter-2.0.1-r1 : lightdm-gtk-greeter.c:1935:9: error: too few arguments to function ‘lightdm_greeter_authenticate’
Summary: x11-misc/lightdm-gtk-greeter-2.0.1-r1 : lightdm-gtk-greeter.c:1935:9: error: ...
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal with 1 vote (vote)
Assignee: Marek Szuba
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2016-07-13 16:53 UTC by Toralf Förster
Modified: 2022-07-01 08:32 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge-history.txt (emerge-history.txt,322.30 KB, text/plain)
2016-07-13 16:53 UTC, Toralf Förster
Details
environment (environment,85.45 KB, text/plain)
2016-07-13 16:53 UTC, Toralf Förster
Details
x11-misc:lightdm-gtk-greeter-2.0.1-r1:20160713-164537.log (x11-misc:lightdm-gtk-greeter-2.0.1-r1:20160713-164537.log,16.22 KB, text/plain)
2016-07-13 16:53 UTC, Toralf Förster
Details
comment (file_588764.txt,93 bytes, text/plain)
2016-07-28 11:11 UTC, Geoff Madden
Details
lightdm-gtk-greeter-2.0.1-lightdm-1.19.patch (lightdm-gtk-greeter-2.0.1-lightdm-1.19.patch,3.47 KB, patch)
2016-08-05 13:35 UTC, Honza Macháček
Details | Diff
add address operator to the added error variable in previous patch (lightdm-gtk-greeter-2.0.1-lightdm-1.19-r1.patch,3.47 KB, patch)
2016-08-12 11:18 UTC, Sven Eden
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2016-07-13 16:53:36 UTC
  CC       lightdm_gtk_greeter-lightdm-gtk-greeter.o
lightdm-gtk-greeter.c: In function ‘start_authentication’:
lightdm-gtk-greeter.c:1935:9: error: too few arguments to function ‘lightdm_greeter_authenticate’
         lightdm_greeter_authenticate (greeter, NULL);
         ^
In file included from /usr/include/lightdm-gobject-1/lightdm.h:14:0,


$ cat emerge-info.txt
  -----------------------------------------------------------------

  This is an unstable amd64 chroot image (named amd64-gnome-systemd-unstable_20160707-230619) at a hardened host acting as a tinderbox.

  -----------------------------------------------------------------

  make.conf: USE="pax_kernel xtpax -cdinstall -oci8 -bindist -aes-ni cdb -cdda cddb custom-optimization dec_av2 ecc -emacs evdev -extraengine fontconfig fortran ftp graphtft ibus -imap isag jadetex javaxml latex ldap lzma -mdnsresponder-compat melt -mp3 mpg123 networking nls ogg openmpi pdo png -printsupport qemu qt3support scripts -scrypt smpeg snmp -sqlite3 sslv2 system-cairo system-icu system-libevent system-libvpx v4l vala -x264 x265 xcb xkb xmp xscreensaver xslt xvmc zip"

  -----------------------------------------------------------------

Portage 2.3.0 (python 3.4.4-final-0, default/linux/amd64/13.0/desktop/gnome/systemd, gcc-5.4.0, glibc-2.23-r2, 4.6.4-hardened x86_64)
=================================================================
System uname: Linux-4.6.4-hardened-x86_64-Intel-R-_Core-TM-_i7-3770_CPU_@_3.40GHz-with-gentoo-2.2
KiB Mem:    16155840 total,    321560 free
KiB Swap:   16777212 total,  16624440 free
Timestamp of repository gentoo: Wed, 13 Jul 2016 16:02:51 +0000
sh bash 4.3_p46
ld GNU ld (Gentoo 2.25.1 p1.1) 2.25.1
app-shells/bash:          4.3_p46::gentoo
dev-java/java-config:     2.2.0-r3::gentoo
dev-lang/perl:            5.24.0-r1::gentoo
dev-lang/python:          2.7.11-r2::gentoo, 3.4.4::gentoo
dev-util/cmake:           3.6.0::gentoo
dev-util/pkgconfig:       0.29.1::gentoo
sys-apps/baselayout:      2.2-r1::gentoo
sys-apps/openrc:          0.21.2::gentoo
sys-apps/sandbox:         2.10-r2::gentoo
sys-devel/autoconf:       2.13::gentoo, 2.69-r2::gentoo
sys-devel/automake:       1.9.6-r4::gentoo, 1.11.6-r2::gentoo, 1.13.4-r1::gentoo, 1.14.1-r1::gentoo, 1.15-r2::gentoo
sys-devel/binutils:       2.25.1-r1::gentoo, 2.26.1::gentoo
sys-devel/gcc:            5.4.0::gentoo
sys-devel/gcc-config:     1.8-r1::gentoo
sys-devel/libtool:        2.4.6-r2::gentoo
sys-devel/make:           4.2.1::gentoo
sys-kernel/linux-headers: 4.6::gentoo (virtual/os-headers)
sys-libs/glibc:           2.23-r2::gentoo
Repositories:

gentoo
    location: /usr/portage
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: 1

local
    location: /usr/local/portage
    masters: gentoo
    priority: 2

ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="*"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=native -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /etc/stunnel/stunnel.conf /usr/lib64/libreoffice/program/sofficerc /usr/share/gnupg/qualified.txt /var/lib/hsqldb /var/lib/i2pd/certificates /var/lib/redmine/config"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c /var/lib/redmine/config/locales /var/lib/redmine/config/settings.yml"
CXXFLAGS="-march=native -O2 -pipe"
DISTDIR="/var/tmp/distfiles"
EMERGE_DEFAULT_OPTS="--verbose-conflicts --color=n --nospinner --tree --quiet-build"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync network-sandbox parallel-fetch preserve-libs protect-owned sandbox sfperms strict test-fail-continue unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://ftp.uni-erlangen.de/pub/mirrors/gentoo rsync://mirror.netcologne.de/gentoo/ ftp://sunsite.informatik.rwth-aachen.de/pub/Linux/gor.bytemark.co.uk/gentoo/ rsync://ftp.snt.utwente.nl/gentoo"
LANG="en_US.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j1"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="X a52 aac acl acpi alsa amd64 berkdb bluetooth branding bzip2 cairo cdb cddb cdr cli colord cracklib crypt cups custom-optimization cxx dbus dec_av2 dri dts dvd dvdr ecc eds emboss encode evdev evo exif fam firefox flac fontconfig fortran ftp gdbm gif glamor gnome gnome-keyring gnome-online-accounts gpm graphtft gstreamer gtk ibus iconv introspection ipv6 isag jadetex javaxml jpeg latex lcms ldap libnotify libsecret lzma mad melt mmx mmxext mng modules mp4 mpeg mpg123 multilib nautilus ncurses networking nls nptl ogg opengl openmp openmpi pam pango pax_kernel pcre pdf pdo png policykit ppds pulseaudio qemu qt3support qt4 readline scripts sdl seccomp session smpeg snmp spell sse sse2 ssl sslv2 startup-notification svg system-cairo system-icu system-libevent system-libvpx systemd tcpd tiff tracker truetype udev udisks unicode upower usb v4l vala vorbis wxwidgets x265 xattr xcb xkb xml xmp xscreensaver xslt xtpax xv xvid xvmc zip zlib" ABI_X86="64" ALSA_CARDS="hda-intel" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx mmx mmxext popcnt sse sse2 sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="evdev synaptics" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-5" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_4" RUBY_TARGETS="ruby20 ruby21" USERLAND="GNU" VIDEO_CARDS="amdgpu fbdev intel nouveau radeon radeonsi vesa dummy v4l" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON
Comment 1 Toralf Förster gentoo-dev 2016-07-13 16:53:41 UTC
Created attachment 440582 [details]
emerge-history.txt
Comment 2 Toralf Förster gentoo-dev 2016-07-13 16:53:44 UTC
Created attachment 440584 [details]
environment
Comment 3 Toralf Förster gentoo-dev 2016-07-13 16:53:46 UTC
Created attachment 440586 [details]
x11-misc:lightdm-gtk-greeter-2.0.1-r1:20160713-164537.log
Comment 4 Juergen Rose 2016-07-19 17:35:34 UTC
I have the same issue.
Comment 5 Perfect Gentleman 2016-07-24 14:21:13 UTC
the same
Comment 6 Kris Scott 2016-07-25 01:55:48 UTC
I'd like to add that lightdm-gtk-greeter compiles just fine with lightdm-1.8.1, so it's most likely some api change in newer versions.
Comment 7 Geoff Madden 2016-07-28 11:11:05 UTC
Created attachment 441800 [details]
comment
Comment 8 Honza Macháček 2016-08-05 13:35:36 UTC
Created attachment 442616 [details, diff]
lightdm-gtk-greeter-2.0.1-lightdm-1.19.patch

I have quickly added as the last parameter GError *error to the affected function calls in x11-misc/lightdm-gtk-greeter-2.0.1-r1, and it compiled successfully against x11-misc/lightdm-1.19.3.
Comment 9 Sven Eden 2016-08-12 11:09:54 UTC
(In reply to Honza Macháček from comment #8)
> Created attachment 442616 [details, diff] [details, diff]
> lightdm-gtk-greeter-2.0.1-lightdm-1.19.patch
> 
> I have quickly added as the last parameter GError *error to the affected
> function calls in x11-misc/lightdm-gtk-greeter-2.0.1-r1, and it compiled
> successfully against x11-misc/lightdm-1.19.3.

The functions want (GError **), so with your patch, the compiler gives out a ton of warnings about incompatible pointer types.

So instead of (example) : 
  lightdm_greeter_authenticate (greeter, NULL, error);
it should patch to :
  lightdm_greeter_authenticate (greeter, NULL, &error);

Then the greeter compiles fine with just one warning about "gdk_cursor_new" being deprecated, which can be happily ignored by now.
Comment 10 Sven Eden 2016-08-12 11:10:41 UTC
Forgot to mention, upstream bug is here:

https://bugs.launchpad.net/lightdm-gtk-greeter/+bug/1606183
Comment 11 Sven Eden 2016-08-12 11:18:43 UTC
Created attachment 443146 [details, diff]
add address operator to the added error variable in previous patch

This patch just sets the proper type of the new error variable by submitting its pointer.
Comment 12 Juergen Rose 2016-09-23 10:11:07 UTC
(In reply to Sven Eden from comment #11)
> Created attachment 443146 [details, diff] [details, diff]
> add address operator to the added error variable in previous patch
> 
> This patch just sets the proper type of the new error variable by submitting
> its pointer.

Thanks, the patch seems to work for me.
Comment 13 Jeroen Roovers (RETIRED) gentoo-dev 2016-10-15 05:20:50 UTC
Can I assume this does not happen when compiling against some versions of x11-misc/lightdm?
Comment 14 Jeroen Roovers (RETIRED) gentoo-dev 2016-10-15 05:50:26 UTC
(In reply to Jeroen Roovers from comment #13)
> Can I assume this does not happen when compiling against some versions of
> x11-misc/lightdm?

Yes, it's fine with stable x11-misc/lightdm-1.16.7.