Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 588690 - net-mail/dbmail - add support for systemd in ebuild
Summary: net-mail/dbmail - add support for systemd in ebuild
Status: UNCONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Thomas Raschbacher
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2016-07-12 12:26 UTC by Edoardo Liverani
Modified: 2021-03-20 19:50 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
The patch (dbmail-3.2.3.ebuild-systemd.patch,591 bytes, patch)
2016-07-12 12:26 UTC, Edoardo Liverani
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Edoardo Liverani 2016-07-12 12:26:25 UTC
Created attachment 440476 [details, diff]
The patch

Attached patch to add support for systemd units scripts in dbmail installation.
I don't know if I should add any other dependency for systemd use flag.
Tested on my system and seems to work.
I think the same modifications could be made on dbmail-3.2.2.ebuild
Comment 1 Brian Evans Gentoo Infrastructure gentoo-dev 2016-07-12 14:58:18 UTC
(In reply to Edoardo Liverani from comment #0)
> Created attachment 440476 [details, diff] [details, diff]
> The patch
> 
> Attached patch to add support for systemd units scripts in dbmail
> installation.
> I don't know if I should add any other dependency for systemd use flag.
> Tested on my system and seems to work.
> I think the same modifications could be made on dbmail-3.2.2.ebuild

Note on the patch:

I suspect systemd IUSE is not needed and --enable-systemd should always be passed to install the service files.
Comment 2 Chris Mayo 2016-07-21 18:50:27 UTC
I think there is a bit more work to do:
- DBMail's dbmail.tmpfiles is for nobody/nobody but Gentoo uses dbmail/dbmail
- For PostgreSQL DBMail units have postgresql.service but Gentoo only has postgresql-${PN}.service
See bug #575930
Comment 3 Chris Mayo 2016-07-23 16:30:22 UTC
Also some discussion about not using Type=forking here:
https://github.com/pjstevns/dbmail/issues/35
Comment 4 Chris Mayo 2016-12-11 20:35:07 UTC
Hopefully --enable-systemd should be optional in future to build with sd_notify:
https://github.com/pjstevns/dbmail/commit/c6773f6b5ff6d87513c3759565df1700128c7e42
Comment 5 Edoardo Liverani 2018-04-04 15:48:37 UTC
Almost two years has passed from this report and dbmail ebuild still lacks systemd support.
Comment 6 Larry the Git Cow gentoo-dev 2018-04-04 20:03:36 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bb2db800978bb3f4e205f0c833666932c9a76cdb

commit bb2db800978bb3f4e205f0c833666932c9a76cdb
Author:     Agostino Sarubbo <ago@gentoo.org>
AuthorDate: 2018-04-04 19:31:49 +0000
Commit:     Agostino Sarubbo <ago@gentoo.org>
CommitDate: 2018-04-04 20:03:29 +0000

    net-mail/dbmail: add systemd support, install docs via dodocs, fix DESCRIPTION.toolong. Leave the upstream suggestions to the maintainer judgment
    
    Bug: https://bugs.gentoo.org/588690
    Package-Manager: Portage-2.3.24, Repoman-2.3.6

 net-mail/dbmail/dbmail-3.2.3-r2.ebuild | 135 +++++++++++++++++++++++++++++++++
 1 file changed, 135 insertions(+)}