Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 588228 - x11-drivers/xf86-video-virtualbox - GCC version check fails with clang
Summary: x11-drivers/xf86-video-virtualbox - GCC version check fails with clang
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Lars Wendler (Polynomial-C) (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 588226
  Show dependency tree
 
Reported: 2016-07-07 13:18 UTC by Michael Palimaka (kensington)
Modified: 2019-04-20 18:48 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
only check gcc when cc is gcc (virtualbox-gcc-check.patch,3.76 KB, patch)
2016-07-11 17:06 UTC, Austin English (RETIRED) 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Palimaka (kensington) gentoo-dev 2016-07-07 13:18:21 UTC 
Due to a change in toolchain-funcs.eclass, gcc-version now queries the active compiler instead of the active GCC. This causes a failure with CC="clang" as clang reports itself as GCC 4.2.

Please see the tracker bug for more information.
Comment 1 Austin English (RETIRED) gentoo-dev 2016-07-11 17:06:56 UTC 
Created attachment 440372 [details, diff]
only check gcc when cc is gcc

This fixes the issue. After this, there are later clang issues that deserves its own bug.
Comment 2 Austin English (RETIRED) gentoo-dev 2016-07-26 00:11:08 UTC 
@masterzorag, could you please ack the attached patch? It's already sat for two weeks, but I just noticed you weren't CC'ed, so I'll hold off for a while longer :)
Comment 3 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2019-04-20 18:48:26 UTC 
Should be fixed as we sed away the gcc version check.