Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 588054 - net-misc/stunnel: add init script support for configuration reload via HUP signal
Summary: net-misc/stunnel: add init script support for configuration reload via HUP si...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Anthony Basile
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2016-07-05 08:43 UTC by Dmitry A. Bakshaev
Modified: 2016-07-06 14:31 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
reload action fro stunnel init script (stunnel_initd_hup.patch,709 bytes, patch)
2016-07-05 08:44 UTC, Dmitry A. Bakshaev
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry A. Bakshaev 2016-07-05 08:43:46 UTC
stunnel supports HUP signal to reload of the configuration file and init script must support it

Reproducible: Always

Steps to Reproduce:
1. /etc/init.d/stunnel reload
Actual Results:  
 * stunnel: unknown function `reload'

Expected Results:  
stunnel configuration reload
Comment 1 Dmitry A. Bakshaev 2016-07-05 08:44:40 UTC
Created attachment 439764 [details, diff]
reload action fro stunnel init script
Comment 2 Anthony Basile gentoo-dev 2016-07-06 10:46:57 UTC
(In reply to Dmitry A. Bakshaev from comment #1)
> Created attachment 439764 [details, diff] [details, diff]
> reload action fro stunnel init script

Is it necessary to do `get_config || return 1`.  I guess your reasoning is that the config file might have changed since the last (re)start.

Also, I assume you tested.

Other than many concerns looks good and I'll add it to the latest version of stunnel in the tree.  Thanks!
Comment 3 Dmitry A. Bakshaev 2016-07-06 11:13:30 UTC
get_config set PIDFILE value
Comment 4 Anthony Basile gentoo-dev 2016-07-06 11:18:14 UTC
(In reply to Dmitry A. Bakshaev from comment #3)
> get_config set PIDFILE value

ah yes.  I've added 5.34-r1 to the tree.  can you please test it since we need to rapid stabilize for bug #588150.
Comment 5 Dmitry A. Bakshaev 2016-07-06 12:14:41 UTC
5.34-r1 successfully tested.
Comment 6 Anthony Basile gentoo-dev 2016-07-06 14:31:53 UTC
(In reply to Dmitry A. Bakshaev from comment #5)
> 5.34-r1 successfully tested.

great, it should be stabilized soon