Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 587930 - sys-apps/portage: glsa-check needs a "bad" exit code on affection.
Summary: sys-apps/portage: glsa-check needs a "bad" exit code on affection.
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Enhancement/Feature Requests (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks: 691278
  Show dependency tree
 
Reported: 2016-07-03 22:34 UTC by Bandie Canis
Modified: 2019-11-02 00:31 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
glsa-check patch for adding a sys.exit(6) in case of affection (0001-glsa-check-test-If-affection-sys.exit-6.patch,644 bytes, application/mbox)
2016-07-03 22:34 UTC, Bandie Canis
Details
man page: EXIT VALUES section added (0002-glsa-check-man-page-Section-EXIT-VALUES-added.patch,801 bytes, patch)
2016-07-04 00:04 UTC, Bandie Canis
Details | Diff
glsa-check patch for adding a sys.exit(6) in case of affection (0001-glsa-check-test-If-affection-sys.exit-6.patch,648 bytes, patch)
2016-07-04 00:06 UTC, Bandie Canis
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bandie Canis 2016-07-03 22:34:04 UTC
Created attachment 439602 [details]
glsa-check patch for adding a sys.exit(6) in case of affection

When I was wroting a bash script with glsa-check I saw that it wouldn't return a non-zero exit code if glsa-check reports an affection.

Here's a patch which makes a sys.exit(6) in case of affection.
Comment 1 Zac Medico gentoo-dev 2016-07-03 22:59:46 UTC
We should add an "EXIT VALUES" section to man/glsa-check.1, like rsync's man page has.
Comment 2 Bandie Canis 2016-07-04 00:04:18 UTC
Created attachment 439606 [details, diff]
man page: EXIT VALUES section added
Comment 3 Bandie Canis 2016-07-04 00:06:33 UTC
Created attachment 439608 [details, diff]
glsa-check patch for adding a sys.exit(6) in case of affection
Comment 4 Brian Dolbec gentoo-dev 2016-07-04 01:55:43 UTC
looks good, thank you
Comment 5 Patrick Lauer gentoo-dev 2016-11-03 14:25:24 UTC
Bump - can you please add this patch or equivalent to one of the next portage releases?
Comment 6 Zac Medico gentoo-dev 2016-11-03 15:58:15 UTC
The patches LGTM.
Comment 7 Bandie Canis 2017-04-18 23:22:13 UTC
Bump.
Comment 8 Zac Medico gentoo-dev 2019-08-19 05:43:03 UTC
glsa-check is included with >=sys-apps/portage-2.3.72 (bug 463952).
Comment 9 Larry the Git Cow gentoo-dev 2019-08-31 03:44:58 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/portage.git/commit/?id=712e2b3fe88fd597914ddf449849b195c15fbcf6

commit 712e2b3fe88fd597914ddf449849b195c15fbcf6
Author:     Aaron Bauman <bman@gentoo.org>
AuthorDate: 2019-08-30 19:29:00 +0000
Commit:     Zac Medico <zmedico@gentoo.org>
CommitDate: 2019-08-31 03:40:20 +0000

    glsa-check: add man page exit values
    
    Bug: https://bugs.gentoo.org/587930
    
    Reported-by: Bandie Yip Kojote <bandie@ttygap.net>
    Signed-off-by: Aaron Bauman <bman@gentoo.org>
    Signed-off-by: Zac Medico <zmedico@gentoo.org>

 man/glsa-check.1 | 12 ++++++++++++
 1 file changed, 12 insertions(+)

https://gitweb.gentoo.org/proj/portage.git/commit/?id=4d9c10704b2eaf6cd7467ff0929a94e64429bfa6

commit 4d9c10704b2eaf6cd7467ff0929a94e64429bfa6
Author:     Aaron Bauman <bman@gentoo.org>
AuthorDate: 2019-08-30 19:18:56 +0000
Commit:     Zac Medico <zmedico@gentoo.org>
CommitDate: 2019-08-31 03:40:06 +0000

    glsa-check: add exit code for affected GLSAs
    
    Bug: https://bugs.gentoo.org/587930
    
    Reported-by: Bandie Yip Kojote <bandie@ttygap.net>
    Signed-off-by: Aaron Bauman <bman@gentoo.org>
    Signed-off-by: Zac Medico <zmedico@gentoo.org>

 bin/glsa-check | 1 +
 1 file changed, 1 insertion(+)
Comment 10 Larry the Git Cow gentoo-dev 2019-08-31 06:21:54 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=05d4de36535c74df5e27784886a7de8d0d8afddb

commit 05d4de36535c74df5e27784886a7de8d0d8afddb
Author:     Zac Medico <zmedico@gentoo.org>
AuthorDate: 2019-08-31 06:13:47 +0000
Commit:     Zac Medico <zmedico@gentoo.org>
CommitDate: 2019-08-31 06:21:36 +0000

    sys-apps/portage: Bump to version 2.3.74
    
     #587930 glsa-check: add exit code for affected GLSAs
     #688902 Add FEATURES=pkgdir-index-trusted
     #690758 Use RTNETLINK to configure the loopback interface
     #692872 glsa-check: forward port --quiet option from gentoolkit
     #693026 rsync: proxychains compatibility
     #693088 glsa-check: forward port remaining changes from gentoolkit
     #693096 emerge: deprecate --changelog option
    
    Bug: https://bugs.gentoo.org/691278
    Bug: https://bugs.gentoo.org/587930
    Bug: https://bugs.gentoo.org/688902
    Bug: https://bugs.gentoo.org/690758
    Bug: https://bugs.gentoo.org/692872
    Bug: https://bugs.gentoo.org/693026
    Bug: https://bugs.gentoo.org/693088
    Bug: https://bugs.gentoo.org/693096
    Package-Manager: Portage-2.3.74, Repoman-2.3.17
    Signed-off-by: Zac Medico <zmedico@gentoo.org>

 sys-apps/portage/Manifest              |   1 +
 sys-apps/portage/portage-2.3.74.ebuild | 261 +++++++++++++++++++++++++++++++++
 2 files changed, 262 insertions(+)