Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 586410 - sys-apps/portage: FEATURES=unmerge-backup should compare BUILD_TIME of existing binary package
Summary: sys-apps/portage: FEATURES=unmerge-backup should compare BUILD_TIME of existi...
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: .tbz2 support (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 608356 portage-2.3.0
  Show dependency tree
 
Reported: 2016-06-19 20:10 UTC by Zac Medico
Modified: 2017-02-05 19:40 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Zac Medico gentoo-dev 2016-06-19 20:10:37 UTC
Currently, FEATURES=unmerge-backup skips the quickpkg call if there is an existing binary package of the same version. It would be better to compare the BUILD_TIME metadata, and call quickpkg if no binary package exists with the same BUILD_TIME (this can involve comparison with multiple binary packages due to FEATURES=binpkg-multi-instance).
Comment 1 Zac Medico gentoo-dev 2016-06-19 21:37:43 UTC
There's a patch in the following branch:

https://github.com/zmedico/portage/tree/bug_586410

I've posted it for review here:

https://archives.gentoo.org/gentoo-portage-dev/message/23b934e413c9071c87f07b5d27c61a88
Comment 3 Fat-Zer 2017-02-05 17:24:54 UTC
Consider documenting the changes... The current documentation says:

> unmerge-backup Call quickpkg(1) to create a backup of each package before
>                it is unmerged (if a binary package of the same version does
>                not already exist).

And it causes a lot of confusion when packages got overwritten when it's already exists...
Comment 4 Zac Medico gentoo-dev 2017-02-05 19:20:24 UTC
This is fixed in portage-2.3.0.

(In reply to Fat-Zer from comment #3)
> Consider documenting the changes... The current documentation says:
> 
> > unmerge-backup Call quickpkg(1) to create a backup of each package before
> >                it is unmerged (if a binary package of the same version does
> >                not already exist).
> 
> And it causes a lot of confusion when packages got overwritten when it's
> already exists...

If you enable FEATURES=binpkg-multi-instance then packages will never overwritten.
Comment 5 Fat-Zer 2017-02-05 19:22:34 UTC
(In reply to Zac Medico from comment #4)
> This is fixed in portage-2.3.0.
> 
> If you enable FEATURES=binpkg-multi-instance then packages will never
> overwritten.

By the word, it's not documented on the man page either...
Comment 6 Zac Medico gentoo-dev 2017-02-05 19:40:20 UTC
(In reply to Fat-Zer from comment #5)
> (In reply to Zac Medico from comment #4)
> > This is fixed in portage-2.3.0.
> > 
> > If you enable FEATURES=binpkg-multi-instance then packages will never
> > overwritten.
> 
> By the word, it's not documented on the man page either...

Thanks, I've opened bug 608356 for this.